Dunedan/0ad
1
0
Fork 0
forked from 0ad/0ad
Code Pull Requests Wiki Activity

Avoid potential integer overflow in pathfinder

Browse Source 
This was SVN commit r8298.
This commit is contained in:
Ykkrosh 2010-10-06 23:50:07 +00:00
parent de673be78a
commit 7b82173bad
1 changed files with 10 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
source/simulation2/components/CCmpPathfinder_Vertex.cpp
View File

@ -719,9 +719,19 @@ void CCmpPathfinder::ComputeShortPath(const IObstructionTestFilter& filter, enti
// If this is the magical goal vertex, move it to near the current vertex
CFixedVector2D npos;
if (n == GOAL_VERTEX_ID)
{
npos = NearestPointOnGoal(vertexes[curr.id].p, goal);
// To prevent integer overflows later on, we need to ensure all vertexes are
// 'close' to the source. The goal might be far away (not a good idea but
// sometimes it happens), so clamp it to the current search range
npos.X = clamp(npos.X, rangeXMin, rangeXMax);
npos.Y = clamp(npos.Y, rangeZMin, rangeZMax);
}
else
{
npos = vertexes[n].p;
}
// Work out which quadrant(s) we're approaching the new vertex from
u8 quad = 0;