Yves
7acdde5c86
The tests crashed on my Debian systems but not on my Ubuntu system. The crash happened in line 142 of SpiderMonkey's ThreadLocal.h. I know that I had to use a workarounnd for contexts to avoid destroying the context that was created first. I also had in mind that in newer versions a JS_Init function got introduced which presumably solves this kind of issues. Based on this experience I assumed runtimes could have a similar problem and this patch indeed fixes the issues. Unfortunately the correct usage of JSRuntimes in that regard is not documented. There's only a rater misterious comment in JSAPI.h which hasn't been cleared up so far and is most likely completely outdated (https://bugzilla.mozilla.org/show_bug.cgi?id=992641). This was SVN commit r14995.
52 lines
1.4 KiB
C++
52 lines
1.4 KiB
C++
/* Copyright (C) 2010 Wildfire Games.
|
|
* This file is part of 0 A.D.
|
|
*
|
|
* 0 A.D. is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* 0 A.D. is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "lib/self_test.h"
|
|
|
|
#include "scriptinterface/ScriptInterface.h"
|
|
#include "scriptinterface/ScriptVal.h"
|
|
|
|
#include "jsapi.h"
|
|
|
|
class TestScriptVal : public CxxTest::TestSuite
|
|
{
|
|
public:
|
|
void test_rooting()
|
|
{
|
|
ScriptInterface script("Test", "Test", g_ScriptRuntime);
|
|
JSContext* cx = script.GetContext();
|
|
JSAutoRequest rq(cx);
|
|
|
|
JSObject* obj = JS_NewObject(cx, NULL, NULL, NULL);
|
|
TS_ASSERT(obj);
|
|
|
|
CScriptValRooted root(cx, OBJECT_TO_JSVAL(obj));
|
|
|
|
JS_GC(script.GetJSRuntime());
|
|
|
|
jsval val = INT_TO_JSVAL(123);
|
|
TS_ASSERT(JS_SetProperty(cx, obj, "test", &val));
|
|
|
|
JS_GC(script.GetJSRuntime());
|
|
|
|
jsval rval;
|
|
TS_ASSERT(JS_GetProperty(cx, obj, "test", &rval));
|
|
TS_ASSERT(JSVAL_IS_INT(rval));
|
|
TS_ASSERT(JSVAL_TO_INT(rval) == 123);
|
|
}
|
|
};
|