elexis
24f97d9fd5
Fixes an occurring leak indicated by the reported clang unused variable
compiler warning, refs #5294, #5550,
by adding the missing glooxwrapper::Jingle::Session::Session destructor
.
Fix two leaks that would have occurred if the according code had been
used:
Delete unused glooxwrapper::Jingle::ICEUDP::ICEUDP instead of adding the
missing destructor.
Delete unused glooxwrapper::Jingle::Content::Content instead of adding
the missing destructor.
Explain why glooxwrapper::Client::registerStanzaExtension doesn't leak
the new StanzaExtensionWrapper.
Explain why glooxwrapper::Jingle::Session::sessionInitiate doesn't leak
the new gloox::Jingle::Content, nor the new gloox::Jingle::ICEUDP.
Explain why glooxwrapper::SessionManager::registerPlugins doesn't leak
the new gloox::Jingle::Content and new gloox::Jingle::ICEUDP.
Explain why glooxwrapper::SessionManager::createSession doesn't leak the
gloox::Jingle::Session.
I will not leak memory in the glooxwrapper.
I will not leak memory in the glooxwrapper.
I will not leak memory in the glooxwrapper.
Use references in the StunClient and glooxwrapper to anticipate any
confusion as to whose obligation it is to delete variables when they are
passed around across several files.
Use static_cast and reinterpret_cast instead of C-style casts in the
StunClient.
Differential Revision: https://code.wildfiregames.com/D2094
Refs D2093 for the reported leaks.
Reviewed By: Josh
Comments By: fcxSanya, Vladislav for D2094, and echotangoecho, leper in
61261d14fc
This was SVN commit r22678.
68 lines
3.1 KiB
C++
68 lines
3.1 KiB
C++
/* Copyright (C) 2019 Wildfire Games.
|
|
* This file is part of 0 A.D.
|
|
*
|
|
* 0 A.D. is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* 0 A.D. is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#ifndef IXMPPCLIENT_H
|
|
#define IXMPPCLIENT_H
|
|
|
|
#include "scriptinterface/ScriptTypes.h"
|
|
|
|
class ScriptInterface;
|
|
namespace StunClient {
|
|
struct StunEndpoint;
|
|
}
|
|
|
|
class IXmppClient
|
|
{
|
|
public:
|
|
static IXmppClient* create(const std::string& sUsername, const std::string& sPassword, const std::string& sRoom, const std::string& sNick, const int historyRequestSize = 0, bool regOpt = false);
|
|
virtual ~IXmppClient() {}
|
|
|
|
virtual void connect() = 0;
|
|
virtual void disconnect() = 0;
|
|
virtual bool isConnected() = 0;
|
|
virtual void recv() = 0;
|
|
virtual void SendIqGetBoardList() = 0;
|
|
virtual void SendIqGetProfile(const std::string& player) = 0;
|
|
virtual void SendIqGameReport(const ScriptInterface& scriptInterface, JS::HandleValue data) = 0;
|
|
virtual void SendIqRegisterGame(const ScriptInterface& scriptInterface, JS::HandleValue data) = 0;
|
|
virtual void SendIqUnregisterGame() = 0;
|
|
virtual void SendIqChangeStateGame(const std::string& nbp, const std::string& players) = 0;
|
|
virtual void SendIqLobbyAuth(const std::string& to, const std::string& token) = 0;
|
|
virtual void SetNick(const std::string& nick) = 0;
|
|
virtual void GetNick(std::string& nick) = 0;
|
|
virtual void kick(const std::string& nick, const std::string& reason) = 0;
|
|
virtual void ban(const std::string& nick, const std::string& reason) = 0;
|
|
virtual void SetPresence(const std::string& presence) = 0;
|
|
virtual void GetPresence(const std::string& nickname, std::string& presence) = 0;
|
|
virtual void GetRole(const std::string& nickname, std::string& role) = 0;
|
|
virtual void GetSubject(std::string& subject) = 0;
|
|
virtual void GUIGetPlayerList(const ScriptInterface& scriptInterface, JS::MutableHandleValue ret) = 0;
|
|
virtual void ClearPresenceUpdates() = 0;
|
|
virtual void GUIGetGameList(const ScriptInterface& scriptInterface, JS::MutableHandleValue ret) = 0;
|
|
virtual void GUIGetBoardList(const ScriptInterface& scriptInterface, JS::MutableHandleValue ret) = 0;
|
|
virtual void GUIGetProfile(const ScriptInterface& scriptInterface, JS::MutableHandleValue ret) = 0;
|
|
virtual JS::Value GuiPollNewMessage(const ScriptInterface& scriptInterface) = 0;
|
|
virtual JS::Value GuiPollHistoricMessages(const ScriptInterface& scriptInterface) = 0;
|
|
virtual void SendMUCMessage(const std::string& message) = 0;
|
|
virtual void SendStunEndpointToHost(const StunClient::StunEndpoint& stunEndpoint, const std::string& hostJID) = 0;
|
|
};
|
|
|
|
extern IXmppClient *g_XmppClient;
|
|
extern bool g_rankedGame;
|
|
|
|
#endif // XMPPCLIENT_H
|