From b12e2822771d81b489bafe54bd20e65a838be48e Mon Sep 17 00:00:00 2001 From: wraitii Date: Fri, 17 Sep 2021 17:01:50 +0000 Subject: [PATCH] Fix black buttons as observer on a GAIA market. Reported by: langbart Reviewed By: bb Fixes #6219 Differential Revision: https://code.wildfiregames.com/D4164 This was SVN commit r25927. --- .../data/mods/public/gui/session/trade/BarterButton.js | 7 +++++++ .../mods/public/gui/session/trade/BarterButtonManager.js | 7 +++---- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/binaries/data/mods/public/gui/session/trade/BarterButton.js b/binaries/data/mods/public/gui/session/trade/BarterButton.js index 09efba3c18..83167875ef 100644 --- a/binaries/data/mods/public/gui/session/trade/BarterButton.js +++ b/binaries/data/mods/public/gui/session/trade/BarterButton.js @@ -49,6 +49,13 @@ class BarterButton */ update(viewedPlayer) { + if (viewedPlayer < 1) + { + this.buyButton.hidden = true; + this.sellButton.hidden = true; + return; + } + this.amountToSell = this.BarterResourceSellQuantity; if (Engine.HotkeyIsPressed("session.massbarter")) diff --git a/binaries/data/mods/public/gui/session/trade/BarterButtonManager.js b/binaries/data/mods/public/gui/session/trade/BarterButtonManager.js index 607f1330c4..773b200e46 100644 --- a/binaries/data/mods/public/gui/session/trade/BarterButtonManager.js +++ b/binaries/data/mods/public/gui/session/trade/BarterButtonManager.js @@ -34,16 +34,15 @@ class BarterButtonManager getSelectedButton() { - for (let button of this.buttons) + for (const button of this.buttons) if (!this.selectedResource || this.selectedResource == button.resourceCode) return button; } update() { - if (this.viewedPlayer >= 1) - for (let button of this.buttons) - button.update(this.viewedPlayer); + for (const button of this.buttons) + button.update(this.viewedPlayer); } }