wowgetoffyourcellphone/0ad
1
0
Fork 0
forked from 0ad/0ad
Code Pull Requests Activity

Fixes logic error in 8d977e4818.

Browse Source 
This was SVN commit r10585.
This commit is contained in:
historic_bruno 2011-11-24 01:16:30 +00:00
parent 8d977e4818
commit 9489076c51
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
binaries/data/mods/public/simulation/components/GuiInterface.js
View File

@ -512,10 +512,10 @@ GuiInterface.prototype.SetBuildingPlacementPreview = function(player, cmd)
// tell GetLosVisibility to force RetainInFog because preview entities set this to false,
// which would show them as hidden instead of fogged
var cmpRangeManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_RangeManager);
var hidden = (cmpRangeManager && cmpRangeManager.GetLosVisibility(ent, player, true) == "hidden");
var visible = (cmpRangeManager && cmpRangeManager.GetLosVisibility(ent, player, true) != "hidden");
var validPlacement = false;
if (!hidden)
if (visible)
{ // Check whether it's obstructed by other entities or invalid terrain
var cmpBuildRestrictions = Engine.QueryInterface(ent, IID_BuildRestrictions);
if (!cmpBuildRestrictions)
@ -524,7 +524,7 @@ GuiInterface.prototype.SetBuildingPlacementPreview = function(player, cmd)
validPlacement = (cmpBuildRestrictions && cmpBuildRestrictions.CheckPlacement(player));
}
var ok = (!hidden && validPlacement);
var ok = (visible && validPlacement);
// Set it to a red shade if this is an invalid location
var cmpVisual = Engine.QueryInterface(ent, IID_Visual);

4
binaries/data/mods/public/simulation/helpers/Commands.js
View File

@ -220,8 +220,8 @@ function ProcessCommand(player, cmd)
// tell GetLosVisibility to force RetainInFog because preview entities set this to false,
// which would show them as hidden instead of fogged
var cmpRangeManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_RangeManager);
var hidden = (cmpRangeManager.GetLosVisibility(ent, player, true) == "hidden");
if (hidden)
var visible = (cmpRangeManager && cmpRangeManager.GetLosVisibility(ent, player, true) != "hidden");
if (!visible)
{
if (g_DebugCommands)
{