Commit Graph

10152 Commits

Author SHA1 Message Date
66267cb714 Remove a check for an edge case where the entrance of a bluff would be cutoff by the players territory.
Instead, reserve some space at the bottom of the slope for an entrance.
Finetune the terrain textures of bluffs depending on the biome.
Patch by _kali, refs #3455.

This was SVN commit r17946.
2016-03-24 15:34:36 +00:00
6312b71911 Improve the resource distribution on the map "Ambush" and maps using bluffs in general. Based on patch by _kali, refs #3455.
Bluffs:
Cover half instead of most of the area of bluffs with forests (to allow
placing CCs / forts there).
Proportionally reduce the likelyhood of placing metal/stone on bluffs.
Compensate the absence of forests on the savanna biome with more
straggler trees.

Ambush:
Place forests also on the mainland (so that players are not immediately
forced to expand to bluffs).
Reduce the amount of berries and animals a bit following 91e8248273.

This was SVN commit r17945.
2016-03-24 14:54:47 +00:00
ebfd214a19 Return Infinity instead of undefined in BuildingAI.GetMaxArrowCount. Refs #3196, #3846 and 82fa9d8f5b.
Notice the previous check `if (count > this.GetMaxArrowCount())`
implicitly relied on
numerical comparisons returning false if one of the two arguments is
undefined.

This was SVN commit r17944.
2016-03-24 13:25:47 +00:00
58d3425ad4 Reduce the number of lobby gamelist updates by roughly 60-80% by eliminating duplicate packets, refs #3847.
This was SVN commit r17943.
2016-03-24 12:08:00 +00:00
572847ddd4 Revert 1f34a004e5.
It breaks the Windows build by using time_t and it changes too many
things to the way lobby messages are processed to be entirely safe to
commit now.
Refs #3832.

As a side effect it reverts e514aca599, refs #3350.

This was SVN commit r17941.
2016-03-23 21:58:23 +00:00
c58bbfaa14 Select observer for defeated players, but keep the current player selected on win.
This was SVN commit r17940.
2016-03-23 13:49:59 +00:00
82fa9d8f5b Fix counting issue with previous commit
This was SVN commit r17939.
2016-03-23 10:01:27 +00:00
63d276b73b Fix counting of arrows in buildings: don't remove entities twice from the garrisonholder. Fixes #3846
This was SVN commit r17938.
2016-03-23 09:04:02 +00:00
e7deb587bb Random-map-script cleanup.
Use constants when checking for the biome type.
Remove unused code for nonexistent biomeID 0 from gaia.js.

This was SVN commit r17937.
2016-03-23 03:05:39 +00:00
cfb8a6e30e Fix confusion between concat and push in map Frontier, patch by _kali.
This was SVN commit r17936.
2016-03-23 02:06:06 +00:00
fc14e733bd Change an Object into a Map, this should stop the deserializer of reordering the keys in some cases and stop an OOS on rejoining. Refs #3375
This was SVN commit r17935.
2016-03-22 20:57:27 +00:00
c43ce2ca55 cleanup of missing semicolon
This was SVN commit r17934.
2016-03-21 20:33:05 +00:00
1a02684cf7 Check for GUID, as the playerIndex doesn't distinguish between observers. Refs #1767.
(Avoid private messages where sender and addressee are identical).

This was SVN commit r17933.
2016-03-21 18:58:52 +00:00
f8d05ed5c3 fix petra serialization (add two variables forgotten, and remove two useless ones)
This was SVN commit r17932.
2016-03-21 18:15:39 +00:00
820846b56b Completely initialise Auras even before ownership is set. Fixes #3843
This was SVN commit r17931.
2016-03-21 16:22:40 +00:00
0448a3de73 Lobby cleanup.
Make sense of the spammonitor by using an object instead of an array and
introducing a global constant instead of using magic numbers.

This was SVN commit r17930.
2016-03-21 14:29:41 +00:00
e514aca599 Display chat-timestamps in the lobby in the correct timezone, refs #3350.
This was SVN commit r17929.
2016-03-21 13:53:22 +00:00
1f34a004e5 Add timestamps to the GUI/chat-notifications sent from XmppClient, even if it's not a historical message.
Correct spammonitor behavior for historical messages and when returning
to the lobby from a game.
Patch by Josh, fixes #3832.

This was SVN commit r17928.
2016-03-21 13:48:22 +00:00
f8a09cf5c1 Seleucid barracks model, actor, AO
This was SVN commit r17926.
2016-03-21 10:25:01 +00:00
8f4daa9dd0 Lobby performance improvement.
Since 8b437a0b1c, updatePlayerList() is called everytime a muc-message
is received, calling playersBox.SelectionChange(), calling
displayProfile() which requests the profile from the server again.
Similar cases should be handled in #3840.

This was SVN commit r17924.
2016-03-21 03:44:01 +00:00
cfe169d2bc Reduce lobbybot load by only requesting a ratinglist when actually opening the leaderboard (as suggested by scythetwirler).
This was SVN commit r17923.
2016-03-21 01:51:05 +00:00
9e338f4461 Barter component cleanup. Replace deprecated for-each.
This was SVN commit r17922.
2016-03-21 00:45:32 +00:00
10b6022557 Convert string to int conversion in the lobby-leaderboard.
This was SVN commit r17921.
2016-03-21 00:38:31 +00:00
91e8248273 Make "Lion's Den" and "Empre" default maps.
Add more animals/berries to "Ambush".
Improve placing of initial resources on all of _kali's maps.

* Increase distance from chickens to CC from `7` to `9` (to account for
roman CCs, refs #3836)
* Increase number of initial trees from `5` to `25` (ensuring players
have enough wood to build a new CC)
* Avoid resource collisions by increasing the minDistance from `2` to
`4` (when not using angles)
* Ensure that initial resources are placed (by first placing mines and
adding retry-loops for the other resources)
  Notice The loop can't be moved to `createObjectGroup` since
    * the parameters (like `mAngle`) also need to randomized again
    * we need to place initial resources in range of the actual
playerbase

This was SVN commit r17920.
2016-03-20 19:03:43 +00:00
b84b9a374a Improve some strings based on translators' feedback.
This was SVN commit r17919.
2016-03-20 18:58:59 +00:00
81948477df fix the test when changing markets, fixes #3838
This was SVN commit r17918.
2016-03-20 14:00:49 +00:00
01b963b259 Update version names to A20
This was SVN commit r17915.
2016-03-19 08:21:00 +00:00
d5059e8e23 Don't use that variable outside of scope.
This was SVN commit r17913.
2016-03-18 17:54:22 +00:00
31fe2770f6 Update credits, refs #3234.
This was SVN commit r17912.
2016-03-18 14:58:13 +00:00
5c6ba10626 Remove blood from skeletons, refs #3455.
This was SVN commit r17911.
2016-03-18 14:02:47 +00:00
3337adcbbe Remove unused variables, duplicate comments and trailing whitespace from volcanic lands.
This was SVN commit r17910.
2016-03-18 12:04:17 +00:00
b623a3a9ff Ensure initial trees are placed on volcanic lands and add missing semicolons. Patch by niektb, refs #3808.
This was SVN commit r17909.
2016-03-18 11:56:00 +00:00
0a8ed799f1 Revert tech applying to auras due to issues. Patch by fatherbushido. Fixes #3830
This was SVN commit r17907.
2016-03-17 08:25:13 +00:00
d44c4fd5c6 Update manual to mention skirmish maps
This was SVN commit r17906.
2016-03-17 08:13:52 +00:00
f7045b23ce Fix some errors reported by translators on Transifex.
This was SVN commit r17905.
2016-03-16 23:27:17 +00:00
19a218cd48 Change the language names for translation credits to the names in the original language.
This removes the loophole in our release process, fixes #3827.

This was SVN commit r17904.
2016-03-16 23:04:10 +00:00
6d52a71d4a Include some new random maps by kali! Style updates by elexis and map previews by niektb.
Refs #3455

This was SVN commit r17903.
2016-03-16 22:59:10 +00:00
29e0a23c8e fix gui for non-sharable dropsites
This was SVN commit r17901.
2016-03-16 16:13:18 +00:00
d033038d69 Also translate specific name in strucTree (translations already exist)
This was SVN commit r17900.
2016-03-16 12:22:23 +00:00
c3324765d2 improved icon from niektb
This was SVN commit r17899.
2016-03-15 20:22:19 +00:00
62f6aa07d0 Add missing round to the armor tooltip. Patch by fatherbushido, fixes #3817.
This was SVN commit r17897.
2016-03-15 05:12:22 +00:00
518ae4fcb2 Lock diplomacy for all players if the locked-teams setting is enabled, fixes #3702.
GUI fix in 17e6b316fa, simulation fix here.

Remove quadruplicated code!
Check in Commands.js as this one handles user input.
Don't check in Player.js as the function should be versatile enough to
change diplomacy from all components, even if teams are locked or
ceasefire active.

This was SVN commit r17896.
2016-03-15 04:53:13 +00:00
d61e315f4d Fix few style issues remarked by leper.
Add a unit (seconds) to the network-timeout warning.
Rename isChatAddressee to parseChatAddressee as it changes the message.
Early return for EnableOOSLog to avoid printing duplicate messages.

This was SVN commit r17895.
2016-03-15 04:37:41 +00:00
a2ecee4168 Rest of the previous commit, refs #3743.
This was SVN commit r17894.
2016-03-15 04:08:07 +00:00
d7fe1b6002 Allow observers to follow the commands and attacks of the currently viewed player, fixes #3743.
If enabled, the camera focuses on the affected units (source and target)
and selects them.

This was SVN commit r17893.
2016-03-15 04:02:15 +00:00
f1d99a9450 Fix a typo which made the "Exit" button in the in-game menu look weird. Thanks niektb for noticing!
This was SVN commit r17892.
2016-03-14 19:47:34 +00:00
dd07241ef7 Petra: fix a bug in attackPlan spotted by leper
This was SVN commit r17891.
2016-03-14 18:08:51 +00:00
c4f607f6e0 Random Map cleanup.
Remove unneeded braces and comments.
Use ++i instead of i++.
Use foo.bar instead of foo["bar"].
Fix a comment.

This was SVN commit r17890.
2016-03-14 18:00:09 +00:00
87da09bf1b Fix tests broken in 028e573759
This was SVN commit r17889.
2016-03-14 17:50:56 +00:00
bedce1e617 Observer fix for shared-dropsites, refs #3791.
This was SVN commit r17887.
2016-03-14 01:23:09 +00:00
541a5567d8 Show the attack-notification to observers.
Allow adding entities to the selection if they are owned by the observed
player.

This was SVN commit r17886.
2016-03-14 00:35:37 +00:00
a7b31398b0 Revert dbbc600dc3, refs #3745, refs #3823
This was SVN commit r17885.
2016-03-13 22:18:31 +00:00
f7ea533ab9 better icon from niektb, refs #3791
This was SVN commit r17884.
2016-03-13 17:38:23 +00:00
9238fc8713 Fix oversight in dbbc600dc3: GetExtendedEntityState is far too demanding for performance, and it is not needed.
Refs #3745

This was SVN commit r17883.
2016-03-13 17:06:12 +00:00
d84ad7799a Limit arrows on certain buildings and ships. Patch by sanderd17, fixes #3196.
Balancing by elexis, reverts fcf7344537 in favor of the new total arrow
limit.

This was SVN commit r17882.
2016-03-13 17:02:18 +00:00
042c9a9334 Allow hosting matches with 8 players and up to 16 observers, fixes #3254.
The host can change the number of allowed observers in running games.

Make sure that joining observers won't take the "slot" of disconnected
players, fixes #3671.

Send clients a new disconnect reason "Server full" instead of letting
them timeout.

This was SVN commit r17881.
2016-03-13 16:52:00 +00:00
dbbc600dc3 Workaround for the multiple-selection commands problem in the case of the back-to-work button. In this case a fix is really needed, as long as the system for handling the selection is not improved.
Also fix the wrong documentation for some functions.

Patch by svott, fixes #3745.

This was SVN commit r17880.
2016-03-13 16:44:21 +00:00
369ca4d012 Allow RMS authors to set the biomeID explicitly or to randomize excluding some biomes.
Add missing semicolon for random_sky.
Fix some scope whitespace issues.

This was SVN commit r17879.
2016-03-13 14:13:38 +00:00
2022aad5d1 decrease the hack armour of fields to favor rushes
This was SVN commit r17878.
2016-03-13 14:09:52 +00:00
6c8004c206 Player component cleanup.
Fat-arrow.
Whitespace fixes for some selected objects.
Newlines to make it more readable.
++i instead of i++.

This was SVN commit r17877.
2016-03-13 13:49:37 +00:00
2e5969c395 Thanks Guuts for #3606 and the other patches you have worked on!
This was SVN commit r17876.
2016-03-13 13:36:25 +00:00
028e573759 allow the use of allied dropsites using tech, fixes #3791
This was SVN commit r17875.
2016-03-13 13:33:21 +00:00
bcfa626bc4 Improve 27b4df0978.
This was SVN commit r17874.
2016-03-12 22:20:15 +00:00
26488bd892 Fix ugly all-bold tooltip for the multiple details area capture bar (reported by bb who has a good eyesight!)
This was SVN commit r17871.
2016-03-12 18:36:28 +00:00
753a79ff67 Fix messages.json
This was SVN commit r17868.
2016-03-12 17:48:16 +00:00
b2f0544215 Delete some broken actor and art files, listed by stanislas69, refs #2524
This was SVN commit r17867.
2016-03-12 15:46:26 +00:00
27b4df0978 Improve some aura and technology descriptions where there was a confusion between speed and time.
Patch by Palaxin, fixes #3600

This was SVN commit r17865.
2016-03-12 13:18:32 +00:00
2546eecbf3 fix modifications (by tech or aura) of garrison and formation auras, fixes #3799, patch by fatherbushido
This was SVN commit r17863.
2016-03-10 21:46:37 +00:00
18829e17c2 Fix comment following e0a9dfd5a2.
This was SVN commit r17862.
2016-03-10 17:11:36 +00:00
e0a9dfd5a2 Allow changing the late-observer flag in a running game, fixes #3669.
Remove it from the game-attributes, since it is not used in the
simulation, nor are they supposed to change in running games.

This was SVN commit r17861.
2016-03-10 11:35:43 +00:00
2305218d9f Optionnames are in lower case, refs #3604.
This was SVN commit r17860.
2016-03-10 11:16:15 +00:00
b71e7e3538 Petra chathelper cleanup.
Inline variables used only once.

This was SVN commit r17859.
2016-03-10 10:44:52 +00:00
aa1e3f6d06 Session cleanup
Simpler errorhandling when fetching GUIInterface-notifications.

This was SVN commit r17858.
2016-03-10 10:15:23 +00:00
4b636fc407 Add a precision to the instructions included in default.cfg.
This was SVN commit r17857.
2016-03-09 21:48:41 +00:00
212d8e7dd0 cleanup of 98b4fe6d00
This was SVN commit r17856.
2016-03-09 21:45:14 +00:00
04586c9e8b Adapt the number-of-players GUI objects of the lobby to support 10 and more clients.
This was SVN commit r17855.
2016-03-09 21:30:53 +00:00
98b4fe6d00 fixes confusion between markets when doing trade, fixes #3812, patch by leper and fatherbushido
This was SVN commit r17854.
2016-03-09 19:54:12 +00:00
7409fe4bec Defeated players are not supposed to do stuff.
Not sending resources on defeat also gives an incentive to completely
defeat players.
Patch by fatherbushido, refs #3265.

This was SVN commit r17853.
2016-03-09 16:11:55 +00:00
2fea95530f Quit if the user requested that while loading the replay list. Fixes #3446.
This was SVN commit r17852.
2016-03-09 16:06:41 +00:00
f2ed0098ee Make the playername-deduplication ("User" -> "User (2)") optional.
Have it disabled by default to fix #3604.
Prevents players from rejoining as late-observers in case they timed-out
on the client-side but not on the server-side.

This was SVN commit r17851.
2016-03-09 15:02:38 +00:00
c0f321b52e Add svott (refs #3736) and fpre (refs #3205) to the contributors.
This was SVN commit r17850.
2016-03-09 14:33:41 +00:00
7c33658fdd ships can be garrisoned in cart superDock with a heal rate, fixes #3810, patch by fatherbushido
This was SVN commit r17849.
2016-03-08 21:50:37 +00:00
a1c6d9149b fix typo from 8725c3ae7a
This was SVN commit r17848.
2016-03-08 18:49:06 +00:00
c7c8d9a5c7 Map previews for 3 random maps and some selected demo maps. Patch by yoreei, fixes #3798.
This was SVN commit r17847.
2016-03-08 17:29:18 +00:00
52bf894c50 Remove naval-tag from flood.
(It can be played without any ships and naval maps are not offered by
default).
Thanks yoreei for reporting.

This was SVN commit r17846.
2016-03-08 14:00:44 +00:00
c511e9c4ec To avoid unintentional joins, ask lobby users if they want to late-join the game as an observer before attempting to do so. Refs #3739.
Add selectedGame() to simplify some checks.
Add linebreaks to hostGame().

This was SVN commit r17845.
2016-03-08 00:18:21 +00:00
ea73e6b3b4 New random map script "Flood". Created by _kali and niektb, refs #3455.
This was SVN commit r17844.
2016-03-07 23:13:52 +00:00
35a13c5080 Remove trailing whitespace.
This was SVN commit r17843.
2016-03-07 17:28:31 +00:00
f3ba295593 Add new contributor _kali to the randommap-script credits.
Add existing contributors niektb and Stan to the map-section for the new
maps in alpha 20.

This was SVN commit r17842.
2016-03-07 17:12:34 +00:00
dd5cc3d02e Gamesetup cleanup.
Inline initializaiton of g_ServerName and fix a typo in e05c8263c5.

This was SVN commit r17841.
2016-03-07 15:05:16 +00:00
fc0f496e3d Fix indentation, refs #3803.
This was SVN commit r17840.
2016-03-07 11:44:03 +00:00
e827ebeb5c Multiplayer-gamesetup cleanup.
Eliminate deprecated for-each.
Quote object keys.
Remove unneeded sprintf from error() calls.
Remove unneeded comments.
Add linebreaks.

This was SVN commit r17839.
2016-03-07 11:42:52 +00:00
05bf260838 Fix the garrisoning flag for some Seleucid buildings, patch by stanislas69. Fixes #3631
This was SVN commit r17838.
2016-03-07 11:38:00 +00:00
49c30ae4b8 Give credit to three awesome contributors, refs #3802.
This was SVN commit r17837.
2016-03-07 10:24:38 +00:00
231586f2fa Aura cleanup.
Eliminate deprecated for-each.
Remove unused variable auraNames.
Use array-filter instead of for-loop.
Fix whitespace.
Don't use affectedPlayers outside of scope.

This was SVN commit r17835.
2016-03-06 14:57:39 +00:00
b1cacacff1 Fix the test of the Player-component following c9b0db7f5f. Patch by fatherbushido, fixes #3803, refs #3522.
This was SVN commit r17834.
2016-03-06 14:02:34 +00:00
5a8d7d1a58 petra cleanup
This was SVN commit r17831.
2016-03-05 16:20:49 +00:00
bcf2c75513 New in-game Credits page, fixes #3744.
This was SVN commit r17830.
2016-03-05 11:52:08 +00:00
1504115c14 I shouldn't rename things.
This was SVN commit r17829.
2016-03-05 11:43:14 +00:00
dfbf874d8b Some string fixes.
This was SVN commit r17828.
2016-03-05 11:30:27 +00:00
6451a4c3c1 Petra: improve choice of workers, fixes #3586, patch from otero
This was SVN commit r17827.
2016-03-04 17:08:45 +00:00
6b19eefdcb cleanup of some foreach
This was SVN commit r17826.
2016-03-04 16:51:52 +00:00
9d2b8a74b7 petra: do not let the ai build too much towers or fortresses
This was SVN commit r17824.
2016-03-03 18:38:13 +00:00
d3e9aa2101 petra: complete changes started in 8d0223d6aa + some cleanup"
This was SVN commit r17823.
2016-03-03 16:18:12 +00:00
7403b92785 petra cleanup: use some arrow functions for sort
This was SVN commit r17822.
2016-03-02 17:10:26 +00:00
8d0223d6aa petra: do not anymore assume that workers are necessarily builders and gatherers
This was SVN commit r17821.
2016-03-02 16:58:02 +00:00
8725c3ae7a Diplomacy-manager cleanup.
Move resource-tributing button code to a custom function.
Shorten comment.
Reuse RESOURCES.
Inline tributeResource.

This was SVN commit r17820.
2016-03-02 16:56:44 +00:00
ed1afbebfc Diplomacy-manager cleanup.
Move the text setup to a custom function.
Reuse colorizePlayernameByID.
Add newlines.

This was SVN commit r17819.
2016-03-02 16:44:57 +00:00
17e6b316fa Diplomacy manager cleanup.
Move the diplomatic stance button initialization to a custom function.
Always hide the button if locked-teams is enabled, refs #3702.
Inline setDiplomacy.

This was SVN commit r17818.
2016-03-02 16:38:05 +00:00
23d37f188a cleanup of some missing tabs
This was SVN commit r17817.
2016-03-02 16:25:14 +00:00
e99e7e33ba Diplomacy manager cleanup.
Split openDiplomacy into four smaller functions, starting with
diplomacyFormatAttackRequestButton in this commit.
Hide the button if the user has no allies and after defeat/win.

This was SVN commit r17816.
2016-03-02 16:23:46 +00:00
af396c9bf9 Player-component cleanup.
Remove deprecated for-each and inline a variable.

This was SVN commit r17815.
2016-03-02 15:00:24 +00:00
458b4a6567 Prohibit user-initiated diplomacy-changes in the simulation while ceasefire is active, refs #2749.
This was SVN commit r17814.
2016-03-02 14:43:18 +00:00
012b686e7c Two early returns. Refs #3265.
This was SVN commit r17813.
2016-03-02 13:42:47 +00:00
163af24a6c cleanup in petra, patch by otero
This was SVN commit r17812.
2016-03-01 17:57:19 +00:00
9c6082ec23 fix garrison aura from heros, patch by fatherbushido
This was SVN commit r17811.
2016-03-01 17:19:16 +00:00
04c94da3cb add some missing spaces in previous commit
This was SVN commit r17810.
2016-03-01 17:12:38 +00:00
c9b0db7f5f Techs can now modify an aura
Wonder population bonus is now an aura (reverted when the wonder is
destroyed) with 10 pop (wonder) with an additionnal +40 with the tech
patch by fatherbushido

This was SVN commit r17809.
2016-03-01 17:10:42 +00:00
b88fd4fe09 fix typo from 8a3bbdf4db
This was SVN commit r17808.
2016-02-29 17:21:35 +00:00
ba0700f612 garrisoning only works between mutual allies
This was SVN commit r17806.
2016-02-28 12:58:52 +00:00
ae309ed550 Replace the inscription on the altar in the main menu background.
The new inscription fits better with the scene, set in Sparta, and is
the Greek original epitaph written on the Cenotaph of Thermopylae,
according to Herodotus:
"Go, tell the Spartans, stranger passing by, that here, obedient to
their laws, we lie."

The previous inscription was apparently a fraction of a sentence and was
about Spartan foreign policy in Ionia.

Suggestion and research by Danny, art by wowgetoffyourcellphone.

This was SVN commit r17805.
2016-02-27 21:31:59 +00:00
c2fad862d8 Correct a typo in 2b0c40d7b2, thanks fede for reporting, fixes #3794.
This was SVN commit r17804.
2016-02-26 22:40:22 +00:00
652ec4f8e5 fix some resetting of gatherer walk animation
This was SVN commit r17802.
2016-02-24 18:57:23 +00:00
ec43274e2b drop carried resources when finishing to build a dropsite
This was SVN commit r17801.
2016-02-24 18:49:28 +00:00
05cf535c58 do not drop resources when garrisoning in allied structure
This was SVN commit r17800.
2016-02-24 17:45:13 +00:00
632901043e Give the mauryan pillar of ashoka a trade speed bonus, fixes #3639.
This was SVN commit r17799.
2016-02-23 23:30:42 +00:00
4ebcae8fa6 Highlight unassigned players in the player-assignments dropdown. Sort by player index. Based on patch by dalerank, fixes #3508.
This was SVN commit r17798.
2016-02-23 22:40:43 +00:00
8b85b72dfc Fix water-terrain painting following 6cc00f6a82. Based on patch by niektb.
This was SVN commit r17797.
2016-02-23 17:47:55 +00:00
2b0c40d7b2 Translate some untranslated strings, refs #3665.
Add a chat message if the control-all units cheat was used, refs #2676.

This was SVN commit r17796.
2016-02-23 17:29:39 +00:00
df42b9caba Commands.js cleanup.
This was SVN commit r17795.
2016-02-23 15:51:09 +00:00
e10ff35869 Commands.js cleanup. Remove unneeded characters of all sorts and use "early-continues".
This was SVN commit r17794.
2016-02-23 15:04:28 +00:00
b60c6f6b15 Commands.js cleanup - fix whitespace.
This was SVN commit r17793.
2016-02-23 14:52:20 +00:00
8a3bbdf4db Commands.js cleanup. Fix remaining for-each loops and increment operators.
This was SVN commit r17792.
2016-02-23 14:49:03 +00:00
e953ca23ba Commands.js cleanup. Replace deprecated for-each.
This was SVN commit r17791.
2016-02-23 14:36:50 +00:00
3a502c0d21 Commands.js cleanup, use fat-arrows.
This was SVN commit r17790.
2016-02-23 14:13:46 +00:00
844566c787 Translate the developer-overlay notification at the receiving end, fixes #3304.
This was SVN commit r17789.
2016-02-23 12:27:34 +00:00
7a5d75be11 Better placement for initial resources on Island Stronghold, based on patch by niektb, refs #3455.
First place all starting entities before placing initial resources to
avoid placing them on each other.
Don't place initial mines near the territory of allies.

This was SVN commit r17788.
2016-02-23 11:51:16 +00:00
c6804aad35 Small RMS library style improvement.
This was SVN commit r17787.
2016-02-23 10:46:32 +00:00
fc298eb3f5 Show time-notifications to observers, refs #3168.
This was SVN commit r17786.
2016-02-22 22:53:48 +00:00
b68654b52d Inlining this is not possible due to the closure.
This was SVN commit r17785.
2016-02-22 17:23:46 +00:00
97c3a166a8 Don't shoot an undocumented arrow from UnitAI if the entity also has a BuildingAI component shooting arrows. Fixes #3763.
Instead, add the arrow to the affected unit templates (except bireme and
trireme, refs #3196).

This was SVN commit r17784.
2016-02-22 17:01:16 +00:00
94ccb153a6 BuildingAI style fixes, refs #3763.
Remove a duplicate targetUnits-, some useless length-checks and unneeded
comments.

This was SVN commit r17783.
2016-02-22 16:44:57 +00:00
8f630789e6 Add/move the Mercenary tag to VisibleClasses, so that all mercenaries are influenced by auras and techs.
Patch by fatherbushido, fixes #3770.

This was SVN commit r17782.
2016-02-22 11:13:31 +00:00
6006edf031 Revert approach to detect offline players without remembering disconnect messages, since it doesn't work for entities of unassigned players. Refs #3677.
Remove unused AIManager.
Inline playerData.

This was SVN commit r17780.
2016-02-20 17:37:19 +00:00
6e9fd4ccf2 fix the ungarrison-all command from allied structures
This was SVN commit r17779.
2016-02-20 15:04:00 +00:00
7918347342 Hide the offline-hint for gaia, refs #3677.
Inline some variables.

This was SVN commit r17777.
2016-02-19 14:36:36 +00:00
4cda0b7040 Don't show the offline hint for AI-assigned players, refs #3677.
This was SVN commit r17774.
2016-02-18 14:46:45 +00:00
6cc00f6a82 Reduce base-height of the random map island stronghold, so units don't walk too far into the water. Patch by niektb, refs #3455.
This was SVN commit r17773.
2016-02-18 13:50:10 +00:00
f8b20d181d Add chat-addressee dropdown, refs #1767.
Add observer-only chat and allow private messages from observer to
observer.
Prevent defeated players from using the team-chat, fixes #3441.

This was SVN commit r17771.
2016-02-18 01:09:56 +00:00
365cbf5b64 Apply auras to resource costs of buildings. Fix some broken loops over a Map. Patch by fatherbushido, fixes #3769.
This was SVN commit r17770.
2016-02-17 23:27:36 +00:00
5aa7a232a4 Ceasefiremanager cleanup.
Let instead of var.
Remove unneeded comments.
Remove trailing whitespace.

This was SVN commit r17767.
2016-02-16 16:23:40 +00:00
badc75b0ad Show wall-aura in the construction tooltip. Patch by s0600204, fixes #3766.
This was SVN commit r17762.
2016-02-15 16:18:57 +00:00
ab57951198 Don't lose the player-offline hint on diplomacy change. Patch by dalerank, fixes #3677.
Also remove the "disconnected" property which has apparently never been
used since its introduction in 81f5e0ac5f.

This was SVN commit r17760.
2016-02-15 15:38:56 +00:00
5485f50948 Defeat the player if the only building owned is an athenian theatron. Patch by fatherbushido, refs #3229.
This was SVN commit r17759.
2016-02-15 13:08:59 +00:00
9ec4f35959 Improve and fix some wrong observer-checks that didn't take defeated players into account. Refs #3168, #3215.
Introduce isPlayerObserver to easily cover that case.
Move some checks and updates into selectViewPlayer and eliminate
setObserverMode.
Initialize the music before changing the perspective.

This was SVN commit r17758.
2016-02-15 12:53:06 +00:00
e3bd2e3fa8 Session cleanup, some simplifications.
This was SVN commit r17757.
2016-02-15 11:39:02 +00:00
823fe17dd4 Entity selection cleanup.
Replace deprecated for-each and remove trailing whitespace.

This was SVN commit r17755.
2016-02-14 23:25:28 +00:00
cb4f8989f1 add a small vision range for aggressive/violent animals, refs #3783
This was SVN commit r17754.
2016-02-14 17:08:55 +00:00
ecb65cd58d petra cleanup
This was SVN commit r17753.
2016-02-13 16:28:23 +00:00
2695e7c77b Remove trailing whitespace, refs #3586.
This was SVN commit r17752.
2016-02-13 11:44:46 +00:00
07133ceb8c fix sound options not propagated to sound manager when reverting/resetting options
This was SVN commit r17749.
2016-02-09 19:00:10 +00:00
ac1f935bad Split GUI updates from onSimulationUpdate.
This was SVN commit r17743.
2016-02-08 14:01:21 +00:00
971d70fa99 allows the user to restore the default game options, refs #3737
This was SVN commit r17739.
2016-02-07 15:10:44 +00:00
43f358563c when saving an option to file, write only that value and not all the content of the user configDB, refs #3737
This was SVN commit r17738.
2016-02-07 11:31:23 +00:00
a2f7d4d82a Show fog of war in observermode, fixes #3168.
This was SVN commit r17735.
2016-02-06 12:56:41 +00:00
875a774da9 New random map "Island Stronghold" by _kali, reworked by niektb. Refs #3455.
This was SVN commit r17734.
2016-02-06 12:30:40 +00:00
b973eebeda Add color indicator to the playerselection in observermode, refs #3168.
This was SVN commit r17733.
2016-02-06 12:19:02 +00:00
22f5b00fce Implement network-warnings, fixes #3264.
Shows a notification if the local client or other players connections
timeout or have bad latency.

This was SVN commit r17730.
2016-02-04 17:14:46 +00:00
4d41bd9622 reorganize options, adding dependences, refs #3737
This was SVN commit r17729.
2016-02-02 21:50:00 +00:00
6052716a78 Random-map-script cleanup.
Move duplicate code of the area- and object-group placing methods to
retryPlacing and two coordinate-randomization functions.
Remove three unused functions (println obsolete since 0e0ed94926,
chooseRand and its helper argsToArray since before 34f1817869).
Inline local calls to GetMapSize() and IsCircularMap(). Keep unused
isCircularMap for API access. Cache variables when retrying.
Map-generation can finish 2% faster.

This was SVN commit r17728.
2016-02-02 16:33:36 +00:00
fdc67768f0 Random random-map-script cleanup.
Simplify sortPlayers.
Use [] instead of new Array.
Remove unneeded braces.
Use JSDoc comments.
Use let instead of var.

This was SVN commit r17727.
2016-02-02 13:35:03 +00:00
b1fbc5b6bd Add newlines, remove unneeded braces.
This was SVN commit r17726.
2016-02-02 11:23:01 +00:00
254f6357f6 Fix a typo (terreins -> terrains).
This was SVN commit r17725.
2016-02-02 10:56:39 +00:00
d8b0404281 petra: some tweaks to be able to better deal with maps like the Migration scenario
i.e. maps with a small starting island, no initial population and no
initial gathering food

This was SVN commit r17723.
2016-01-29 19:41:34 +00:00
30bd2baeeb fix Migration scenario map
This was SVN commit r17722.
2016-01-29 18:53:09 +00:00
b65f2a338c petra cleanup
This was SVN commit r17720.
2016-01-28 19:44:18 +00:00
c46e64c4d2 fix dropdown option
This was SVN commit r17719.
2016-01-28 18:44:50 +00:00
30d0bcd350 petra remove some useless code
This was SVN commit r17718.
2016-01-28 18:30:39 +00:00
75d91c6a26 petra: fix account of foundation popbonus when checking if new houses are needed
This was SVN commit r17717.
2016-01-27 18:30:49 +00:00
06eadf2bc4 petra cleanup + some tweaks
This was SVN commit r17716.
2016-01-27 18:17:55 +00:00
564941c477 fix wall buildings after f34dc412b6, refs #3647
This was SVN commit r17715.
2016-01-26 19:04:29 +00:00
91ed318f0d fix typo
This was SVN commit r17714.
2016-01-26 18:36:59 +00:00
08d326cef5 clone the rallypoint data from cmd, fixes #3751
This was SVN commit r17713.
2016-01-26 18:03:06 +00:00
090f2ccfe5 Don't modify the command object. Refs #3647.
This was SVN commit r17712.
2016-01-26 17:58:15 +00:00
ab16ddb256 Show a more specific disconnect-message in case the host closed the server. Refs #3264, #3570.
This was SVN commit r17710.
2016-01-25 12:56:30 +00:00
68f87cb556 Proportionally adapt cost for civ-specific fortresses since the generic template was changed in 6b9b863747.
Thanks Hannibal Barca for reporting.

This was SVN commit r17706.
2016-01-25 00:38:33 +00:00
4a58c7f8b6 petra: improve performance of docks positioning (was really slow) + some cleanup
This was SVN commit r17705.
2016-01-24 20:43:27 +00:00
7c6f35b2c0 Update the unit selection for observers, refs #3168.
Don't disable the deselect button.

This was SVN commit r17704.
2016-01-24 12:33:34 +00:00
aa8541e8ce 2-player skirmish map "Golden Island". Created by scythetwirler and updated by niektb.
This was SVN commit r17697.
2016-01-23 23:02:25 +00:00
27d04d0165 Close previously opened dialogs before opening a new one. Fixes #3535. Also remove many duplicate calls.
This was SVN commit r17692.
2016-01-23 03:40:31 +00:00
4fbd550cda Correct z-ordering issue for chat panel and input form. Patch by dalerank, refs #3535.
This was SVN commit r17691.
2016-01-23 03:24:00 +00:00
c97a91f7bd Change displayed string instead of throwing errors in case of unspecified civs in replays.
This was SVN commit r17690.
2016-01-23 02:41:35 +00:00
dd7287c1c8 additionnal petra cleanup
fix a case with foundation access not defined

This was SVN commit r17688.
2016-01-22 19:46:51 +00:00
c955d74330 petra cleanup (thanks to leper's suggestion)
This was SVN commit r17687.
2016-01-22 18:45:28 +00:00
fdf7dabe18 check that the target can be built or repaired inside the canRepair function
This was SVN commit r17685.
2016-01-21 20:49:57 +00:00
edb16dafbb petra cleanup
This was SVN commit r17684.
2016-01-21 20:38:56 +00:00
df7da846ad some cleanup in ai api
This was SVN commit r17683.
2016-01-21 20:23:19 +00:00
cccd33e7fe petra cleanup
This was SVN commit r17679.
2016-01-20 19:45:47 +00:00
87886b7b03 fix the AI for the switch to the Repairable component
This was SVN commit r17678.
2016-01-20 19:04:38 +00:00
dd545bdbf1 petra cleanup
This was SVN commit r17677.
2016-01-19 23:19:40 +00:00
0a64bf25cd Sort globals, add JSDoc comments, remove trailing whitespace.
This was SVN commit r17676.
2016-01-19 18:09:34 +00:00
5308b95aa8 Let observers change perspective. Refs #3168.
Disable the controls for observers (unless the developer-option is
enabled).
Don't check for g_IsObserver, since observers should be able to use the
developer overlay as well.
Update all GUI elements when changing the perspective using
onSimulationUpdate().
Enable observermode for defeated players.

This was SVN commit r17675.
2016-01-19 17:23:16 +00:00
0e48b7df75 Update the idle-worker-button onSimulationUpdate. Patch by svott, fixes #3736.
This was SVN commit r17674.
2016-01-19 16:04:59 +00:00
e035e3e985 Restore the replay selection after deletion. Based on patch by dalerank, fixes #3473.
This was SVN commit r17672.
2016-01-18 20:16:45 +00:00
a6f8b3b3d7 rename the Close button, refs #3737
This was SVN commit r17671.
2016-01-18 19:44:48 +00:00
a59833102f Specify the default column sorting order in XML instead of JS.
Ref #2405, #3473.

This was SVN commit r17670.
2016-01-18 19:23:14 +00:00
9481c168bd petra cleanup
This was SVN commit r17669.
2016-01-18 19:20:09 +00:00
69f4614768 Don't use two different default values ("name" and "") in JS for the default lobby sorting order in b8fce56821, refs #2405.
Supplement a variable g_GameStatusOrder missing in 66ec6dbf12.

This was SVN commit r17668.
2016-01-18 18:29:16 +00:00
8d2a73bf52 Show the aura of city walls in the structure tree. Patch by s0600204, refs #3655.
This was SVN commit r17662.
2016-01-18 03:24:26 +00:00
c20ee2ad5e add dropdown capacity for options, fixes #2596
remove use of eval for function execution

This was SVN commit r17657.
2016-01-17 21:50:54 +00:00
dc9d1fff11 restore sorting in template, refs #3741
This was SVN commit r17656.
2016-01-17 15:44:38 +00:00
cfb2216b8c Remove JSDebugger. Closes #2419, #2973. Refs #410, #2348, #3708.
https://bugzilla.mozilla.org/show_bug.cgi?id=1069694

This was SVN commit r17655.
2016-01-17 00:34:33 +00:00
b4d11cf747 let farms have the terrain ownership, fixes #3741
This was SVN commit r17654.
2016-01-16 12:47:33 +00:00
c4d9b64fe5 fix undef var when in petra debug
This was SVN commit r17653.
2016-01-15 19:12:34 +00:00
0d33ec31cc Pass cmd to TryTransformWallToGate as that is used when debugging commands. Patch by dalerank. Fixes #3694.
This was SVN commit r17651.
2016-01-14 16:21:05 +00:00
419453e212 Allow randommap-scripts to set a custom fail-limit when placing objects. Patch by Stan, fixes #3567.
This was SVN commit r17649.
2016-01-13 23:51:46 +00:00
ad7c53e65a Adapt the template for corrals to the limitation in UnitAI.CanGarrison. Refs #3412.
This was SVN commit r17648.
2016-01-13 23:33:08 +00:00
aa7ef01105 rename reload to revert
This was SVN commit r17646.
2016-01-13 22:32:42 +00:00
5c61f68600 Rework the logics of options loading to allow more flexibility (i.e. adding a min or max value for number inputs)
Fix some problems when reloading saved options, refs #3511
Add the material quality option, refs #3737
Reload and Save buttons are only enabled when some options have changed.

This was SVN commit r17645.
2016-01-13 22:01:36 +00:00
cd22f9f722 Display all auras in the tooltips (even if there are some with an identical name). Patch by s0600204, fixes #3655.
Add an aura tooltip to the construction panel.
Remove duplicate tooltip code for the training panel.
Eliminate for-each and use the aura ID in GetTemplateDataHelper, since
only that is a unique identifier.
Change the name from "Hero Aura" to "Garrisoned Capture Aura" for that
aura that every hero has.

This was SVN commit r17644.
2016-01-13 19:32:17 +00:00
c9a22ec7c3 Show the population bonus of buildings in the structure tree. Patch by s0600204, fixes #3738.
Also fix a newline in the tooltip.

This was SVN commit r17643.
2016-01-13 18:44:30 +00:00
e6a8cd8c5e Do not redeclare a variable.
This was SVN commit r17640.
2016-01-12 20:04:33 +00:00
ee6a5fd915 Extend defensive-stance tooltip and add quotes to object keys.
This was SVN commit r17639.
2016-01-12 18:32:30 +00:00
a02f797169 Add unit-stance tooltips. Patch by bb, fixes #3385.
Reorder cases, correct indentation, remove unneeded variable and
sprintf.

This was SVN commit r17638.
2016-01-12 16:19:43 +00:00
83efc8363e fix old typos in sound config
This was SVN commit r17636.
2016-01-11 22:39:03 +00:00
f0fc36138d cleanup of previous patches
This was SVN commit r17627.
2016-01-10 22:46:37 +00:00
3246b02cda make easy AI levels easier and hard levels harders by also applying the bonus/malus to trade, fixes #3722
add some info on AI levels in the AI config window

This was SVN commit r17626.
2016-01-10 21:57:01 +00:00
7fa2962c45 allows changing options for one session without having to save them, fixes #3511
changes on text or number options are now detected without any need of
typing Return, fixes #2451
graphic options (using the renderer type) are now properly saved when
changed
sound options (using the function type) are still not saved

This was SVN commit r17625.
2016-01-10 21:41:34 +00:00
e9511d21d5 Fix bug in d4d05c6236.
This was SVN commit r17624.
2016-01-10 17:25:40 +00:00
8c7b6dceaa Show status-bars of all players to observers, fixes #3215.
This was SVN commit r17623.
2016-01-10 16:47:57 +00:00
8859f33b38 Rename PickFriendlyEntitiesOnScreen to PickPlayerEntitiesOnScreen.
Rename PickFriendlyEntitiesInRect to PickPlayerEntitiesInRect.
Rename PickSimilarFriendlyEntities to PickSimilarPlayerEntities.
Add comment.
Refs #3215.

This was SVN commit r17622.
2016-01-10 14:47:09 +00:00
ead85b1572 Update the control-all-units checkbox when changing the perspective and onSimulationUpdate so that it always shows the correct value.
This was SVN commit r17619.
2016-01-10 00:59:28 +00:00
9a623a8e00 Style fixes.
This was SVN commit r17618.
2016-01-09 23:01:07 +00:00
6b710f35b0 Show the selection panels to observers / in replays, fixes #3731.
This allows observers to see the training queue, researched techs, unit
stance, constructable buildings, garrisoned units, market prices etc.
for all players without changing the perspective.
All buttons are disabled if the user isn't allowed to control the
affected player.
Notice updateUnitCommands() fills out the panel differently in case of
selecting an allied building.
Extends the GUIInterface methods "GetNeededResources",
"CheckTechnologyRequirements" and "IsTechnologyResearched" to optionally
take a different player-argument.

This was SVN commit r17617.
2016-01-09 22:01:08 +00:00
9b922ebadd Remove invisible character introduced in deaa224785.
This was SVN commit r17616.
2016-01-09 12:12:42 +00:00
491cba314a Translate some notification messages. Refs #3665.
This was SVN commit r17614.
2016-01-08 23:22:45 +00:00
caa81a1d31 Remove garrison code duplication.
This was SVN commit r17613.
2016-01-08 23:02:26 +00:00
deaa224785 Fix some Gallic leader names, based on historic_bruno's suggestions. Fixes #3675
This was SVN commit r17612.
2016-01-08 20:12:25 +00:00
87a93b2498 Add version command line option. Fixes #2965.
This was SVN commit r17611.
2016-01-08 19:35:33 +00:00
b4f187b8d4 Defeat the player if he/she has no more units, nor buildings that can train units. Fixes #3229.
This was SVN commit r17610.
2016-01-08 12:21:40 +00:00
5b60f2d1f6 Display the buildrate of foundations in the tooltip. Patch by bb, fixes #3395.
This was SVN commit r17609.
2016-01-08 11:53:48 +00:00
e1e4a00ad7 Enable sky by default. This is usually not needed during gameplay (no sky visible), but it is with cinematic, committed in 89aef0b6eb, where camera can point to the sky.
Can still be disabled in game options menu.
Refs: #3301.

This was SVN commit r17607.
2016-01-07 12:38:43 +00:00
a7743e95b9 cleanup of unused counters
This was SVN commit r17605.
2016-01-06 21:15:58 +00:00
e0a1e2beb1 Session cleanup.
Don't send the simstate as an argument of reportGame().
Eliminate a for-each loop.
Remove some superfluous comments.

This was SVN commit r17604.
2016-01-05 03:02:59 +00:00
b18cd3254c Test FixedVector{2,3}D script conversions, and test calling functions of the prototypes.
Also ENSURE that the given value identifier is actually present in the
cache instead of creating one if it is not.

This was SVN commit r17603.
2016-01-04 21:41:40 +00:00
4c4beb8450 cleanup
This was SVN commit r17602.
2016-01-04 18:10:04 +00:00
9f334036ef Do not align object properties.
Do not construct objects if they only contain two atomic elements.
Revert getDisconnectReason so as to have a custom message for the error
case. Add a warning.

This was SVN commit r17601.
2016-01-04 17:59:12 +00:00
24b14fe201 allow the AI to build near walls (but not gates), fixes #3725
This was SVN commit r17596.
2016-01-03 21:04:23 +00:00
89aef0b6eb Cinematic camera core functionality. Patch by Vladislav Belov.
Based on existing code that was still around from an old(not working)
implementation.
Supports basic control from trigger scirpts (queue, start and stop
camera paths) and works in multiplayer.

This was SVN commit r17594.
2016-01-03 12:41:04 +00:00
a32aa3b6cf petra: use the proper attack number when deserializing, refs #3720
This was SVN commit r17592.
2016-01-02 18:16:50 +00:00