0ad/0ad-community-mod-a26
0ad/0ad-community-mod-a26
3
0
Fork 2
Code Issues Pull Requests 1 Actions Projects Releases 2 Wiki Activity

allow walls and palisades to be built over trees, destorying trees upon completion. #4

Merged
Stan merged 2 commits from real_tabasco_sauce/0ad-community-mod-a26:walls_destroy_woods into main 2024-09-08 21:51:42 +02:00
Conversation 0 Commits 2 Files Changed 2 +75 -80
real_tabasco_sauce commented 2024-08-30 08:11:28 +02:00
Contributor
Copy Link

this PR allows walls and palisades to be placed over wood and destroys the wood resources upon completion. This should make wall placement easier when players want to fully wall. It is unlikely to be abused to destory wood since the walls have to be fully built to destroy the wood.

this PR allows walls and palisades to be placed over wood and destroys the wood resources upon completion. This should make wall placement easier when players want to fully wall. It is unlikely to be abused to destory wood since the walls have to be fully built to destroy the wood.
real_tabasco_sauce added 1 commit 2024-08-30 08:11:29 +02:00
allow walls and palisades to be built over trees, destorying trees upon completion.
All checks were successful
CI Pipeline / Check Templates (All) (pull_request) Has been skipped
Details
CI Pipeline / Package and Sign Mod (pull_request) Has been skipped
Details
CI Pipeline / Check Templates (PR) (pull_request) Successful in 14s
Details
pre-commit / build (pull_request) Successful in 20s
Details
314d5da201
real_tabasco_sauce added 1 commit 2024-09-02 02:35:54 +02:00
add missing check to foundation.js
All checks were successful
CI Pipeline / Check Templates (All) (pull_request) Has been skipped
Details
CI Pipeline / Check Templates (PR) (pull_request) Successful in 13s
Details
CI Pipeline / Package and Sign Mod (pull_request) Has been skipped
Details
pre-commit / build (pull_request) Successful in 15s
Details
2813270802
Stan merged commit 673b47d582 into main 2024-09-08 21:51:42 +02:00
real_tabasco_sauce reviewed 2024-09-10 17:37:18 +02:00
community-mod/simulation/components/Foundation.js
@ -273,10 +272,10 @@ Foundation.prototype.Commit = function()
// animation to indicate they're waiting for people to get
// out the way
return false;
real_tabasco_sauce commented 2024-09-10 17:37:18 +02:00
Author
Contributor
Copy Link

"
I haven't looked at the code. But the crash is due to something not being serializable (the serialization error from above). Could be a NaN value for instance from the error it seems total builder is NaN
"
@Stan we should continue the conversation here i guess.
I saw that this value was NaN but also that several other values in the error message were uninitialized.
I added return false; back, which messed up wall building in forests but didn't result in any crashes.

" I haven't looked at the code. But the crash is due to something not being serializable (the serialization error from above). Could be a NaN value for instance from the error it seems total builder is NaN " @Stan we should continue the conversation here i guess. I saw that this value was NaN but also that several other values in the error message were uninitialized. I added return false; back, which messed up wall building in forests but didn't result in any crashes.
Stan commented 2024-09-10 17:52:00 +02:00
Owner
Copy Link

The game cannot reliably serialize NaN values as it actually represents a range of values. So any attempts to serialize them will crash.

In SP you can use the rejoin test button in the Alt+D menu to look for serialization issues.

The game cannot reliably serialize NaN values as it actually represents a range of values. So any attempts to serialize them will crash. In SP you can use the rejoin test button in the Alt+D menu to look for serialization issues.
👍 1
Stan commented 2024-09-10 17:54:00 +02:00
Owner
Copy Link

Discussion should probably be in #31 actually.

Discussion should probably be in #31 actually.
👍 1
real_tabasco_sauce commented 2024-09-10 19:03:54 +02:00
Author
Contributor
Copy Link

the region test button is greyed out

the region test button is greyed out
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: 0ad/0ad-community-mod-a26#4
No description provided.
Delete Branch "real_tabasco_sauce/0ad-community-mod-a26:walls_destroy_woods"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?