Fix ABI incompatibility with --with-system-mozjs185 in debug mode (see #990).

This was SVN commit r10535.

build/premake/extern_libs4.lua

@@ -472,6 +472,7 @@ extern_lib_defs = {
 		compile_settings = function()
 			if _OPTIONS["with-system-mozjs185"] then
 				pkgconfig_cflags("mozjs185")
+				defines { "WITH_SYSTEM_MOZJS185" }
 			else
 				if os.is("windows") then
 					include_dir = "include-win32"

source/scripting/ScriptGlue.cpp

@@ -274,7 +274,7 @@ JSBool GetBuildTimestamp(JSContext* cx, uintN argc, jsval* vp)
 	return JS_TRUE;
 }
 
-#ifdef DEBUG
+#if MOZJS_DEBUG_ABI
 void DumpHeap(const char* basename, int idx, JSContext* cx)
 {
 	char filename[64];
@@ -292,7 +292,7 @@ JSBool DumpHeaps(JSContext* cx, uintN argc, jsval* vp)
 	UNUSED2(cx);
 	UNUSED2(argc);
 
-#ifdef DEBUG
+#if MOZJS_DEBUG_ABI
 	static int i = 0;
 
 	if (ScriptingHost::IsInitialised())

source/scriptinterface/ScriptInterface.cpp

@@ -1099,7 +1099,7 @@ void* ScriptInterface::GetPrivate(JSContext* cx, JSObject* obj)
 
 void ScriptInterface::DumpHeap()
 {
-#ifdef DEBUG
+#if MOZJS_DEBUG_ABI
 	JS_DumpHeap(m->m_cx, stderr, NULL, 0, NULL, (size_t)-1, NULL);
 #endif
 	fprintf(stderr, "# Bytes allocated: %d\n", JS_GetGCParameter(GetRuntime(), JSGC_BYTES));

source/scriptinterface/ScriptTypes.h

@@ -33,11 +33,31 @@
 // the ones that are needed and this avoids conflicting definitions
 # define JS_SYS_TYPES_H_DEFINES_EXACT_SIZE_TYPES
 
-#else
+#else // If not Windows, then Unix:
+
 # define XP_UNIX
+
+// In DEBUG mode, jsval defaults to struct types. Normally we build separate
+// debug/release mode versions of the library, but when using --with-system-mozjs185
+// it's always a release mode library, so we have to disable struct types for
+// ABI compatibility
+# if defined(DEBUG) && defined(WITH_SYSTEM_MOZJS185)
+#  define JS_NO_JSVAL_JSID_STRUCT_TYPES
+# endif
+
 #endif
 // (we don't support XP_OS2 or XP_BEOS)
 
+
+// Guess whether the library was compiled with the release-mode or debug-mode ABI
+// (for JS_DumpHeap etc)
+#if defined(DEBUG) && !defined(WITH_SYSTEM_MOZJS185)
+# define MOZJS_DEBUG_ABI 1
+#else
+# define MOZJS_DEBUG_ABI 0
+#endif
+
+
 #include <cstring> // required by jsutil.h
 
 // SpiderMonkey wants the DEBUG flag

source/tools/atlas/AtlasScript/ScriptInterface.h

@@ -28,7 +28,14 @@
 # define JS_NO_JSVAL_JSID_STRUCT_TYPES
 
 #else
+
 # define XP_UNIX
+
+// (See comment in scriptinterface/ScriptTypes.h)
+# if defined(DEBUG) && defined(WITH_SYSTEM_MOZJS185)
+#  define JS_NO_JSVAL_JSID_STRUCT_TYPES
+# endif
+
 #endif // (we don't support XP_OS2 or XP_BEOS)
 
 #ifdef __GNUC__