Disable "assignment operator could not be generated" warning globally on Windows, since it's never useful.

This was SVN commit r16192.

source/graphics/TerrainTextureManager.cpp

@@ -31,13 +31,6 @@
 #include "ps/CLogger.h"
 #include "ps/Filesystem.h"
 
-// Disable "'boost::algorithm::detail::is_classifiedF' : assignment operator could not be generated"
-// and "find_format_store.hpp(74) : warning C4100: 'Input' : unreferenced formal parameter"
-#if MSC_VERSION
-#pragma warning(disable:4512)
-#pragma warning(disable:4100)
-#endif
-
 #include <boost/algorithm/string.hpp>
 
 

source/lib/external_libraries/icu.h

@@ -23,15 +23,6 @@
 #ifndef INCLUDED_ICU
 #define INCLUDED_ICU
 
-#if MSC_VERSION
-# pragma warning(push)
-# pragma warning(disable:4512) // "assignment operator could not be generated"
-#endif
-
 #include <unicode/smpdtfmt.h>
 
-#if MSC_VERSION
-# pragma warning(pop)
-#endif
-
 #endif	// #ifndef INCLUDED_ICU

source/lib/pch/pch_warnings.h

@@ -13,6 +13,7 @@
 # pragma warning(disable:4324)	// structure was padded due to __declspec(align())
 # pragma warning(disable:4351)	// yes, default init of array entries is desired
 # pragma warning(disable:4355)	// 'this' used in base member initializer list
+# pragma warning(disable:4512)	// assignment operator could not be generated
 # pragma warning(disable:4718)	// recursive call has no side effects, deleting
 # pragma warning(disable:4786)	// identifier truncated to 255 chars
 # pragma warning(disable:4996)	// function is deprecated

source/ps/ArchiveBuilder.cpp

@@ -26,11 +26,6 @@
 #include "lib/file/vfs/vfs_util.h"
 #include "ps/XML/Xeromyces.h"
 
-// Disable "'boost::algorithm::detail::is_classifiedF' : assignment operator could not be generated"
-#if MSC_VERSION
-#pragma warning(disable:4512)
-#endif
-
 #include <boost/algorithm/string.hpp>
 
 CArchiveBuilder::CArchiveBuilder(const OsPath& mod, const OsPath& tempdir) :

source/ps/CLogger.cpp

@@ -31,13 +31,6 @@
 #include <ctime>
 #include <iostream>
 
-// Disable "'boost::algorithm::detail::is_classifiedF' : assignment operator could not be generated"
-// and "find_format_store.hpp(74) : warning C4100: 'Input' : unreferenced formal parameter"
-#if MSC_VERSION
-#pragma warning(disable:4512)
-#pragma warning(disable:4100)
-#endif
-
 #include <boost/algorithm/string/replace.hpp>
 
 static const double RENDER_TIMEOUT = 10.0; // seconds before messages are deleted

source/renderer/MikktspaceWrap.h

@@ -21,11 +21,6 @@
 
 #include "third_party/mikktspace/mikktspace.h"
 
-// Disable useless MSVC warning
-#if MSC_VERSION
-# pragma warning(disable:4512) // "assignment operator could not be generated"
-#endif
-
 class MikkTSpace
 {
 

source/scriptinterface/ScriptTypes.h

@@ -75,7 +75,6 @@
 # pragma warning(push)
 # pragma warning(disable:4480) // "nonstandard extension used: specifying underlying type for enum"
 # pragma warning(disable:4100) // "unreferenced formal parameter"
-# pragma warning(disable:4512) // "assignment operator could not be generated"
 # pragma warning(disable:4265) // "class has virtual functions, but destructor is not virtual"
 # pragma warning(disable:4251) // "class 'X' needs to have dll-interface to be used by clients of struct 'Y'"
 # pragma warning(disable:4005) // "macro redefinition"

source/simulation2/system/ParamNode.cpp

@@ -27,11 +27,6 @@
 
 #include <sstream>
 
-// Disable "'boost::algorithm::detail::is_classifiedF' : assignment operator could not be generated"
-#if MSC_VERSION
-#pragma warning(disable:4512)
-#endif
-
 #include <boost/algorithm/string.hpp>
 #include <boost/algorithm/string/join.hpp>	// this isn't in string.hpp in old Boosts