wraitii
25490bfec3
- Check for pending exceptions after function calls and script executions. - Call LOGERROR instead of JS_ReportError when there is a conversion error in FromJSVal, since that can only be called from C++ (where JS errors don't really make sense). Instead, C++ callers of FromJSVal should handle the failure and, themselves, either report an error or simply do something else. - Wrap JS_ReportError since that makes updating it later easier. This isn't a systematical fix since ToJSVal also ought return a boolean for failures, and we probably should trigger errors instead of warnings on 'implicit' conversions, rather a preparation diff. Part of the SM52 migration, stage: SM45 compatible (actually SM52 incompatible, too). Based on a patch by: Itms Comments by: Vladislavbelov, Stan` Refs #742, #4893 Differential Revision: https://code.wildfiregames.com/D3093 This was SVN commit r24187.
75 lines
2.0 KiB
C++
75 lines
2.0 KiB
C++
/* Copyright (C) 2020 Wildfire Games.
|
|
* This file is part of 0 A.D.
|
|
*
|
|
* 0 A.D. is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* 0 A.D. is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "simulation2/system/ComponentTest.h"
|
|
|
|
#include "simulation2/components/ICmpCommandQueue.h"
|
|
|
|
class TestCmpCommandQueue : public CxxTest::TestSuite
|
|
{
|
|
public:
|
|
void setUp()
|
|
{
|
|
CXeromyces::Startup();
|
|
}
|
|
|
|
void tearDown()
|
|
{
|
|
CXeromyces::Terminate();
|
|
}
|
|
|
|
void test_basic()
|
|
{
|
|
ComponentTestHelper test(g_ScriptContext);
|
|
ScriptRequest rq(test.GetScriptInterface());
|
|
|
|
std::vector<SimulationCommand> empty;
|
|
|
|
ICmpCommandQueue* cmp = test.Add<ICmpCommandQueue>(CID_CommandQueue, "", SYSTEM_ENTITY);
|
|
|
|
TS_ASSERT(test.GetScriptInterface().Eval("var cmds = []; function ProcessCommand(player, cmd) { cmds.push([player, cmd]); }"));
|
|
|
|
JS::RootedValue cmd(rq.cx);
|
|
|
|
TS_ASSERT(test.GetScriptInterface().Eval("([1,2,3])", &cmd));
|
|
cmp->PushLocalCommand(1, cmd);
|
|
|
|
TS_ASSERT(test.GetScriptInterface().Eval("({\"x\":4})", &cmd));
|
|
cmp->PushLocalCommand(-1, cmd);
|
|
|
|
test.Roundtrip();
|
|
|
|
// Process the first two commands
|
|
cmp->FlushTurn(empty);
|
|
|
|
TS_ASSERT(test.GetScriptInterface().Eval("({\"y\":5})", &cmd));
|
|
cmp->PushLocalCommand(10, cmd);
|
|
|
|
// Process the next command
|
|
cmp->FlushTurn(empty);
|
|
|
|
// Process no commands
|
|
cmp->FlushTurn(empty);
|
|
|
|
test.Roundtrip();
|
|
|
|
std::string output;
|
|
TS_ASSERT(test.GetScriptInterface().Eval("JSON.stringify(cmds)", output));
|
|
TS_ASSERT_STR_EQUALS(output, "[[1,[1,2,3]],[-1,{\"x\":4}],[10,{\"y\":5}]]");
|
|
}
|
|
};
|