• Joined on 2024-08-19
Stan commented on pull request 0ad/0ad#6951 2024-08-22 19:36:44 +02:00
ignore visual studio .vs/ files

Oh you need to push --force else it won't work. When you rewrite history should force push.

Stan commented on pull request 0ad/0ad#6951 2024-08-22 19:26:22 +02:00
ignore visual studio .vs/ files

How did you "update the branch" ?

Stan commented on pull request 0ad/0ad#6951 2024-08-22 18:36:40 +02:00
ignore visual studio .vs/ files

You can also force push to rewrite the history of the PR :)

Stan commented on pull request 0ad/0ad#6954 2024-08-22 18:31:48 +02:00
Use ruff for linting Python files

This looks good to me but I would like to hear @Itms' opinion about this hybrid workflow :)

Stan commented on pull request 0ad/0ad#6951 2024-08-22 18:14:10 +02:00
ignore visual studio .vs/ files

Yes! It should be in your profile settings. You can add multiple. You might want to stick with one though ;)

Stan commented on pull request 0ad/0ad#6951 2024-08-22 17:45:48 +02:00
ignore visual studio .vs/ files

Btw @real_tabasco_sauce note that your commit author is different from your login

Stan commented on pull request 0ad/0ad#6954 2024-08-22 16:41:11 +02:00
Use ruff for linting Python files

uses: pre-commit/action@v3.0.0

Stan commented on pull request 0ad/0ad#6954 2024-08-22 16:41:11 +02:00
Use ruff for linting Python files

Might put it in a .gitea folder

Stan suggested changes for 0ad/0ad#6954 2024-08-22 16:41:11 +02:00
Use ruff for linting Python files
Stan approved 0ad/0ad#6952 2024-08-22 15:19:21 +02:00
Deny hosting a game if a player is muted
Stan commented on pull request 0ad/0ad#6952 2024-08-22 15:19:13 +02:00
Deny hosting a game if a player is muted

Just to make sure this doesn't affect LAN hosting does it?

Stan commented on pull request 0ad/0ad#6951 2024-08-22 15:15:33 +02:00
ignore visual studio .vs/ files

On the one hand, I'm a bit concerned about putting extra strain on contributors with regards to removing stuff from the gitignore. On Windows at least they already have to do much more setup than…

Stan commented on pull request 0ad/0ad#6954 2024-08-22 11:30:19 +02:00
Use ruff for linting Python files

As to having one general python file, I'm not sure as those tools are quite distinct

Stan pushed to fix-log-file-name at Stan/Limnoria 2024-08-22 11:23:05 +02:00
7654869723 Try to fix the urls
Stan created branch fix-log-file-name in Stan/Limnoria 2024-08-22 10:53:09 +02:00
Stan pushed to fix-log-file-name at Stan/Limnoria 2024-08-22 10:53:09 +02:00
fc2cce85ae Escape authors from title
6bef1d8f08 Match historic configuration
Compare 2 commits »
Stan commented on issue 0ad/0ad#6955 2024-08-22 10:24:14 +02:00
Cannot connect to multiplayer with my friend

Similar to #6672, #6616 and #5279

See #6616 and wiki:FAQ#Multiplayer

Stan commented on pull request 0ad/0ad#6954 2024-08-22 10:17:10 +02:00
Use ruff for linting Python files

Looks like my runner is not accessible to you here...

Stan commented on pull request 0ad/0ad#6953 2024-08-22 09:44:20 +02:00
Reduce time needed for STUN

Looks alright to me. Maybe num_msg could not be abbreviated also max_tries sounds like it should be camelCase. Any way to test this on a bad network?

Stan commented on pull request 0ad/0ad#6952 2024-08-22 08:12:04 +02:00
Deny hosting a game if a player is muted

Maybe that would be better done in C++ as it's less likely to be modded out. But correlated with an Xparta change it might be okay.

They'd still be able to spew nonsense in the gamesetup and in…