• Joined on 2024-08-19
Vantha commented on pull request 0ad/0ad#6980 2024-09-23 12:29:53 +02:00
Add a Tips and Tricks page containing the loading screen tips

Anything else to change here?

Probably not, just to let you know the plan, was afk over the weekend and need to have an other look at the latest incarnation first (probably today), then…

Vantha commented on pull request 0ad/0ad#6980 2024-09-23 11:11:39 +02:00
Add a Tips and Tricks page containing the loading screen tips

Anything else to change here?

Vantha commented on pull request 0ad/0ad#6980 2024-09-22 11:28:41 +02:00
Add a Tips and Tricks page containing the loading screen tips

Ok, I'm gonna convert it into a bool then. A comment can take over the task of explaining.

Vantha pushed to tips-page at Vantha/0ad 2024-09-22 11:25:02 +02:00
0f90ad8a73 Clean up tip image files to prevent libpng warnings
1792f0d065 Add a Tips and Tricks page containing the loading screen tips
Compare 2 commits »
Vantha commented on pull request 0ad/0ad#6980 2024-09-21 15:31:28 +02:00
Add a Tips and Tricks page containing the loading screen tips

I see. It was a misunderstanding on my side then.

Vantha pushed to tips-page at Vantha/0ad 2024-09-21 15:31:02 +02:00
1c2173859e Clean up tip image files to prevent libpng warnings
f61c22a91f Add a Tips and Tricks page containing the loading screen tips
Compare 2 commits »
Vantha commented on pull request 0ad/0ad#6980 2024-09-21 11:56:48 +02:00
Add a Tips and Tricks page containing the loading screen tips

No pressing reason. Only so it comes across clearly in loading.js and TipsPage.js what the construction parameter does. Should I change it?

Vantha commented on pull request 0ad/0ad#6980 2024-09-21 11:51:45 +02:00
Add a Tips and Tricks page containing the loading screen tips

Wouldn't the line get a bit too long?

Vantha pushed to tips-page at Vantha/0ad 2024-09-21 11:49:35 +02:00
14f2008e07 Clean up tip image files to prevent libpng warnings
5e3b12f54e Add a Tips and Tricks page containing the loading screen tips
Compare 2 commits »
Vantha commented on pull request 0ad/0ad#6980 2024-09-20 15:50:53 +02:00
Add a Tips and Tricks page containing the loading screen tips

Oh, ok. I just pushed a fix.

Vantha pushed to tips-page at Vantha/0ad 2024-09-20 15:48:20 +02:00
4363d9e3b9 Clean up tip image files to prevent libpng warnings
210318c75e Add a Tips and Tricks page containig the loading screen tips
Compare 2 commits »
Vantha commented on pull request 0ad/0ad#6980 2024-09-20 12:57:58 +02:00
Add a Tips and Tricks page containing the loading screen tips

I was able to fix the issue with the PNGs. They contained some broken (but redundant) color profile chunks, removing them did away with the warnings.

Vantha pushed to tips-page at Vantha/0ad 2024-09-20 12:52:13 +02:00
8f33aa6031 Clean up tip image files to prevent libpng warnings
bd480b9470 Add a Tips and Tricks page containig the loading screen tips
Compare 2 commits »
Vantha commented on pull request 0ad/0ad#6980 2024-09-20 12:51:10 +02:00
Add a Tips and Tricks page containing the loading screen tips

Hmm, it works fine for me. The icon should be defined in setup.xml .

Vantha commented on pull request 0ad/0ad#6980 2024-09-20 00:05:08 +02:00
Add a Tips and Tricks page containing the loading screen tips

Thanks for checking over. Turns out I uploaded a partially outdated version yesterday - which is why some paths were still incorrect and the one translation wasn't deleted yet. Anyway, I…

Vantha commented on pull request 0ad/0ad#6980 2024-09-20 00:04:52 +02:00
Add a Tips and Tricks page containing the loading screen tips

I decided for removing the translation entirely... ?

Vantha commented on pull request 0ad/0ad#6980 2024-09-20 00:02:55 +02:00
Add a Tips and Tricks page containing the loading screen tips

Actually, no. The CloseButton class reads this string and sets it as the tooltip.

Vantha pushed to tips-page at Vantha/0ad 2024-09-19 23:56:07 +02:00
3e8c474f55 Add a Tips and Tricks page containing the loading screen tips
Vantha commented on pull request 0ad/0ad#6980 2024-09-18 23:05:56 +02:00
Add a Tips and Tricks page containing the loading screen tips

Ok. I moved the images accordingly and also got rid of the translation of the bullet format.

Vantha pushed to tips-page at Vantha/0ad 2024-09-18 23:03:29 +02:00
8315437863 Add a Tips and Tricks page containing the loading screen tips
b15eb6909e Remove unnecessary comments in selection_details.js
798cff1f6f Left-click the portrait to follow the entity
230c7ca27d Add EditorConfig options for Python
e56ebb3f46 Enable ruff naming rules
Compare 30 commits »