griffkid4/0ad
1
0
Fork 0
forked from 0ad/0ad
Code Pull Requests Activity

GUI cleanup.

Browse Source 
Point out missing functionality and unused properties in the
implementation of checkboxes.
Don't specify a useless font tag for checkboxes in the templates.

This was SVN commit r18419.
This commit is contained in:
elexis 2016-06-21 14:38:06 +00:00
parent 9e526614be
commit 0f807c643a
3 changed files with 7 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
binaries/data/mods/public/gui/replaymenu/replay_menu.xml
View File

@ -103,7 +103,7 @@
<object name="rightPanel" size="100%-250 30 100%-20 100%-20" >
<!-- Compatibility Filter Checkbox -->
<object name="compatibilityFilter" type="checkbox" checked="true" style="ModernTickBox" size="0 4 20 100%" font="sans-bold-13">
<object name="compatibilityFilter" type="checkbox" checked="true" style="ModernTickBox" size="0 4 20 100%">
<action on="Press">displayReplayList();</action>
</object>
@ -212,7 +212,7 @@
</object>
<!-- "Show Spoiler" Checkbox -->
<object name="showSpoiler" type="checkbox" checked="false" style="ModernTickBox" size="10 100%-27 30 100%" font="sans-bold-13">
<object name="showSpoiler" type="checkbox" checked="false" style="ModernTickBox" size="10 100%-27 30 100%">
<action on="Press">displayReplayDetails();</action>
</object>

2
binaries/data/mods/public/gui/session/top_panel.xml
View File

@ -13,7 +13,7 @@
<object name="optionFollowPlayer" size="50%+64 4 50%+256 100%" hidden="true">
<!-- Checkbox -->
<object name="followPlayer" type="checkbox" checked="false" style="ModernTickBox" size="0 4 20 100%" font="sans-bold-13">
<object name="followPlayer" type="checkbox" checked="false" style="ModernTickBox" size="0 4 20 100%">
<action on="Press">g_FollowPlayer = !g_FollowPlayer;</action>
</object>

4
source/gui/CCheckBox.cpp
View File

@ -23,6 +23,10 @@
#include "ps/CLogger.h"
#include "ps/CStrIntern.h"
/**
* TODO: Since there is no call to DrawText, the checkbox won't render any text.
* Thus the font, caption, textcolor and other settings have no effect.
*/
CCheckBox::CCheckBox()
{
AddSetting(GUIST_float, "buffer_zone");