1
0
forked from 0ad/0ad
0ad/source/lobby
wraitii 25490bfec3 Improve JS Exception handling.
- Check for pending exceptions after function calls and script
executions.
- Call LOGERROR instead of JS_ReportError when there is a conversion
error in FromJSVal, since that can only be called from C++ (where JS
errors don't really make sense). Instead, C++ callers of FromJSVal
should handle the failure and, themselves, either report an error or
simply do something else.
- Wrap JS_ReportError since that makes updating it later easier.

This isn't a systematical fix since ToJSVal also ought return a boolean
for failures, and we probably should trigger errors instead of warnings
on 'implicit' conversions, rather a preparation diff.

Part of the SM52 migration, stage: SM45 compatible (actually SM52
incompatible, too).

Based on a patch by: Itms
Comments by: Vladislavbelov, Stan`
Refs #742, #4893

Differential Revision: https://code.wildfiregames.com/D3093
This was SVN commit r24187.
2020-11-15 18:29:17 +00:00
..
glooxwrapper Officially drop support for Visual Studio 2013, which stopped working after 3a839517ce, fixes #5379. 2020-01-12 20:04:22 +00:00
scripting Improve JS Exception handling. 2020-11-15 18:29:17 +00:00
Globals.cpp Fix building with --without-lobby. Fixes #2249. 2013-11-08 15:28:44 +00:00
IXmppClient.h Rewrite lobby page to use class semantics, add more gamedetails labels, improve performance using batch processing and caching and gain possibility for game creation/player-join/leave events, refs #5387. 2019-11-21 13:44:41 +00:00
StanzaExtensions.cpp Secure lobby authentication - prevent joins as a different player 2018-03-12 00:23:40 +00:00
StanzaExtensions.h Secure lobby authentication - prevent joins as a different player 2018-03-12 00:23:40 +00:00
XmppClient.cpp Improve JS Exception handling. 2020-11-15 18:29:17 +00:00
XmppClient.h Remove DefPersistentRooted and unneeded includes. 2020-11-12 08:24:30 +00:00