phosit/0ad
1
0
Fork 0
forked from 0ad/0ad
Code Pull Requests Activity

Fix removal of email addresses from PO-files

Browse Source 
The regex for removing the email address of the last translator from
PO-files contained two bugs causing it not to match:

1. It didn't account for text after the email address and PO-files
   from Transifex contain the year of the last translation there.
2. It expected a second `\\n"` at the end of the line, instead of `\n"`.

This commit fixes both of these issues and simplifies the regexes. It
also ensures that the text after the email address is kept as well.

Patch by: @Dunedan
Accepted by: @Stan
Differential Revision: https://code.wildfiregames.com/D5290
This was SVN commit r28130.
This commit is contained in:
Dunedan 2024-06-26 04:19:43 +00:00
parent f5b416c63b
commit 75753abd2e
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
source/tools/i18n/cleanTranslationFiles.py
View File

@ -1,6 +1,6 @@
#!/usr/bin/env python3
#
# Copyright (C) 2023 Wildfire Games.
# Copyright (C) 2024 Wildfire Games.
# This file is part of 0 A.D.
#
# 0 A.D. is free software: you can redistribute it and/or modify
@ -31,9 +31,8 @@ import sys, os, glob, re, fileinput
from i18n_helper import l10nFolderName, transifexClientFolder, projectRootDirectory
def main():
# Prepare some regexes.
translatorMatch = re.compile("(# [^,<]*)(?: <.*>)?(?:, [0-9,-]{4,9})")
lastTranslatorMatch = re.compile("(\"Last-Translator: [^,<]*)(?: <.*>)?( ?\\\\n\")")
translatorMatch = re.compile(r"^(#\s+[^,<]*)\s+<.*>(.*)")
lastTranslatorMatch = re.compile(r"^(\"Last-Translator:[^,<]*)\s+<.*>(.*)")
for root, folders, _ in os.walk(projectRootDirectory):
for folder in folders:
@ -53,11 +52,11 @@ def main():
if m.group(1) in usernames:
line = ""
else:
line = m.group(1) + "\n"
line = m.group(1) + m.group(2) + "\n"
usernames.append(m.group(1))
m2 = lastTranslatorMatch.match(line)
if m2:
line = m2.group(1) + "\\n\"\n"
line = re.sub(lastTranslatorMatch, r"\1\2", line)
elif line.strip() == "# Translators:":
reached = True
sys.stdout.write(line)