phosit/0ad
1
0
Fork 0
forked from 0ad/0ad
Code Pull Requests Activity

Use override in classes derived from AbstractProfileTable.

Browse Source 
Patch By: phosit
Differential Revision: https://code.wildfiregames.com/D4825
This was SVN commit r27414.
This commit is contained in:
Vladislav Belov 2023-01-10 22:32:08 +00:00
parent 2442c948ba
commit b31e698f12
4 changed files with 28 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
source/network/NetStats.h
View File

@ -1,4 +1,4 @@
/* Copyright (C) 2020 Wildfire Games.
/* Copyright (C) 2023 Wildfire Games.
* This file is part of 0 A.D.
*
* 0 A.D. is free software: you can redistribute it and/or modify
@ -42,12 +42,12 @@ public:
CNetStatsTable();
CNetStatsTable(const ENetPeer* peer);
virtual CStr GetName();
virtual CStr GetTitle();
virtual size_t GetNumberRows();
virtual const std::vector<ProfileColumn>& GetColumns();
virtual CStr GetCellText(size_t row, size_t col);
virtual AbstractProfileTable* GetChild(size_t row);
CStr GetName() override;
CStr GetTitle() override;
size_t GetNumberRows() override;
const std::vector<ProfileColumn>& GetColumns() override;
CStr GetCellText(size_t row, size_t col) override;
AbstractProfileTable* GetChild(size_t row) override;
void LatchHostState(const ENetHost* host);

21
source/ps/Profile.cpp
View File

@ -1,4 +1,4 @@
/* Copyright (C) 2022 Wildfire Games.
/* Copyright (C) 2023 Wildfire Games.
* This file is part of 0 A.D.
*
* 0 A.D. is free software: you can redistribute it and/or modify
@ -42,17 +42,16 @@ class CProfileNodeTable : public AbstractProfileTable
{
public:
CProfileNodeTable(CProfileNode* n);
virtual ~CProfileNodeTable();
// Implementation of AbstractProfileTable interface
virtual CStr GetName();
virtual CStr GetTitle();
virtual size_t GetNumberRows();
virtual const std::vector<ProfileColumn>& GetColumns();
CStr GetName() override;
CStr GetTitle() override;
size_t GetNumberRows() override;
const std::vector<ProfileColumn>& GetColumns() override;
virtual CStr GetCellText(size_t row, size_t col);
virtual AbstractProfileTable* GetChild(size_t row);
virtual bool IsHighlightRow(size_t row);
CStr GetCellText(size_t row, size_t col) override;
AbstractProfileTable* GetChild(size_t row) override;
bool IsHighlightRow(size_t row) override;
private:
/**
@ -90,10 +89,6 @@ CProfileNodeTable::CProfileNodeTable(CProfileNode* n)
node = n;
}
CProfileNodeTable::~CProfileNodeTable()
{
}
// Short name (= name of profile node)
CStr CProfileNodeTable::GetName()
{

12
source/renderer/Renderer.cpp
View File

@ -86,12 +86,12 @@ public:
CRendererStatsTable(const CRenderer::Stats& st);
// Implementation of AbstractProfileTable interface
CStr GetName();
CStr GetTitle();
size_t GetNumberRows();
const std::vector<ProfileColumn>& GetColumns();
CStr GetCellText(size_t row, size_t col);
AbstractProfileTable* GetChild(size_t row);
CStr GetName() override;
CStr GetTitle() override;
size_t GetNumberRows() override;
const std::vector<ProfileColumn>& GetColumns() override;
CStr GetCellText(size_t row, size_t col) override;
AbstractProfileTable* GetChild(size_t row) override;
private:
/// Reference to the renderer singleton's stats

14
source/scriptinterface/ScriptStats.h
View File

@ -1,4 +1,4 @@
/* Copyright (C) 2020 Wildfire Games.
/* Copyright (C) 2023 Wildfire Games.
* This file is part of 0 A.D.
*
* 0 A.D. is free software: you can redistribute it and/or modify
@ -33,12 +33,12 @@ public:
void Add(const ScriptInterface* scriptInterface, const std::string& title);
void Remove(const ScriptInterface* scriptInterface);
virtual CStr GetName();
virtual CStr GetTitle();
virtual size_t GetNumberRows();
virtual const std::vector<ProfileColumn>& GetColumns();
virtual CStr GetCellText(size_t row, size_t col);
virtual AbstractProfileTable* GetChild(size_t row);
CStr GetName() override;
CStr GetTitle() override;
size_t GetNumberRows() override;
const std::vector<ProfileColumn>& GetColumns() override;
CStr GetCellText(size_t row, size_t col) override;
AbstractProfileTable* GetChild(size_t row) override;
private:
std::vector<std::pair<const ScriptInterface*, std::string> > m_ScriptInterfaces;