1
0
forked from 0ad/0ad
0ad/source
wraitii 8ac104b07a Fix 'gliding' behaviour at the end of movement by moving the PossiblyAtDestination check earlier.
Units in 0 A.D. exhibited a "gliding" behaviour at the end of a
movement, e.g. they switched to the Idle animation and still moved a
little bit.

The reason for this behaviour is that entities check if they reached
their destination after moving. Other components (unitAI mostly) will
then possibly change animations and such, resulting in a movement over
the turn while the entity is possibly now in another animation state
than "move".
Instead, what should be done is checking if the entity has arrived
before moving, so if UnitAI calls StopMoving, then entity won't move at
all on the same turn, and the gliding effect vanishes.

The STATE_STOPPING state is made un-necessary by this change, since this
off-by-one mistake was the reason for its existence. It can be removed
(see downstream).

Differential Revision: https://code.wildfiregames.com/D1898
This was SVN commit r22365.
2019-06-11 18:51:55 +00:00
..
collada Fix compiler warnings on VS 2015, refs #3439, refs #5069. 2018-03-10 09:58:53 +00:00
graphics Clean up ThreadUtil, use standard C++11 constructs instead of custom ones. 2019-06-06 19:30:48 +00:00
gui [CChart] Add a percentage format and round displayed integers 2019-05-13 21:23:26 +00:00
i18n Simple refactoring of Singleton. Make it non-copyable. 2019-01-13 15:11:40 +00:00
lib Adds Camera test for ortho projection. 2019-06-05 19:55:37 +00:00
lobby recieve -> receive 2019-04-07 16:06:10 +00:00
maths Fixes a misprint that was introduced in cb83d494e0. 2019-04-25 18:59:41 +00:00
mocks More FreeBSD build fixes. 2012-01-30 06:21:11 +00:00
network Clean up ThreadUtil, use standard C++11 constructs instead of custom ones. 2019-06-06 19:30:48 +00:00
pch Update precompiled headers to improve build times. 2019-05-26 07:21:12 +00:00
ps Clean up ThreadUtil, use standard C++11 constructs instead of custom ones. 2019-06-06 19:30:48 +00:00
renderer Fixes a typo introduced in cb048b4738 in shore calculations, found by Angen and fixes style notes by elexis. 2019-06-03 20:19:18 +00:00
scriptinterface SpiderMonkey-related changes in preparation for the upgrade to SpiderMonkey 45, refs #4893. 2019-01-13 16:37:41 +00:00
simulation2 Fix 'gliding' behaviour at the end of movement by moving the PossiblyAtDestination check earlier. 2019-06-11 18:51:55 +00:00
soundmanager Clean up ThreadUtil, use standard C++11 constructs instead of custom ones. 2019-06-06 19:30:48 +00:00
third_party Use libsodium for cryptography. 2018-04-08 21:41:31 +00:00
tools Clean up ThreadUtil, use standard C++11 constructs instead of custom ones. 2019-06-06 19:30:48 +00:00
main.cpp Fix a crash on some system when Alt-tabbing during game setup. 2019-05-28 13:18:32 +00:00
test_setup.cpp Fix string format of the JS test assertion failure following 7c2e9027c2 (cxxtest expects a char* instead of a std::wstring, so newlines were printed as \n characters). 2017-10-13 21:56:45 +00:00