sera/0ad
1
0
Fork 0
forked from 0ad/0ad
Code Pull Requests Activity

Fix some issues found by static analysis (clang-analyzer and cppcheck).

Browse Source 
This was SVN commit r16801.
This commit is contained in:
leper 2015-06-21 18:46:31 +00:00
parent caa8f51c2e
commit 5a0b9b0e70
3 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
source/gui/CInput.cpp
View File

@ -1873,9 +1873,7 @@ void CInput::UpdateText(int from, int to_before, int to_after)
check_point_row_start = check_point_row_end = -1;
}
// set 'from' to the from row we'll destroy
// and 'to' to 'to_after'
from = destroy_row_from->m_ListStart;
destroy_row_from->m_ListStart;
if (destroy_row_to != m_CharacterPositions.end())
to = destroy_row_to->m_ListStart; // notice it will iterate [from, to[, so it will never reach to.

6
source/scriptinterface/ScriptRuntime.cpp
View File

@ -333,8 +333,6 @@ void* ScriptRuntime::jshook_function(JSContext* cx, JSAbstractFramePtr fp, bool
void ScriptRuntime::PrepareContextsForIncrementalGC()
{
for (std::list<JSContext*>::iterator itr = m_Contexts.begin(); itr != m_Contexts.end(); itr++)
{
JS::PrepareZoneForGC(js::GetCompartmentZone(js::GetContextCompartment(*itr)));
}
for (JSContext* const& ctx : m_Contexts)
JS::PrepareZoneForGC(js::GetCompartmentZone(js::GetContextCompartment(ctx)));
}

2
source/third_party/tinygettext/src/dictionary_manager.cpp vendored
View File

@ -121,7 +121,7 @@ DictionaryManager::get_dictionary(const Language& language)
std::string best_filename;
int best_score = 0;
for(std::vector<std::string>::iterator filename = files.begin(); filename != files.end(); filename++)
for (std::vector<std::string>::iterator filename = files.begin(); filename != files.end(); ++filename)
{
// check if filename matches requested language
if (has_suffix(*filename, ".po"))