forked from 0ad/0ad
[Fix] Code inconsistency in Attack.js for range accuracy
The proper schema is: Attack/Ranged/Projectile/Spread Fixes this oversight in Attack.js and adjusts the relevant technologies and trigger.
This commit is contained in:
parent
f87dfebc71
commit
3ba8b0c1a5
@ -356,7 +356,7 @@ Trigger.prototype.RemoveSpread = function()
|
||||
{
|
||||
let cmpModifiersManager = Engine.QueryInterface(SYSTEM_ENTITY, IID_ModifiersManager);
|
||||
cmpModifiersManager.AddModifiers("no_promotion", {
|
||||
"Attack/Ranged/Spread": [{ "affects": ["Unit"], "replace": 0 }],
|
||||
"Attack/Ranged/Projectile/Spread": [{ "affects": ["Unit"], "replace": 0 }],
|
||||
}, 4); // player 2 is ent 4
|
||||
};
|
||||
|
||||
|
@ -674,7 +674,7 @@ Attack.prototype.PerformAttack = function(type, target)
|
||||
let predictedHeight = cmpTargetPosition.GetHeightAt(predictedPosition.x, predictedPosition.z);
|
||||
|
||||
// Add inaccuracy based on spread.
|
||||
let distanceModifiedSpread = ApplyValueModificationsToEntity("Attack/" + type + "/Spread", +this.template[type].Projectile.Spread, this.entity) *
|
||||
const distanceModifiedSpread = ApplyValueModificationsToEntity("Attack/" + type + "/Projectile/Spread", +this.template[type].Projectile.Spread, this.entity) *
|
||||
predictedPosition.horizDistanceTo(selfPosition) / 100;
|
||||
|
||||
let randNorm = randomNormal2D();
|
||||
|
@ -20,7 +20,7 @@
|
||||
"researchTime": 40,
|
||||
"tooltip": "Archers −20% ranged attack spread.",
|
||||
"modifications": [
|
||||
{ "value": "Attack/Ranged/Spread", "multiply": 0.8 }
|
||||
{ "value": "Attack/Ranged/Projectile/Spread", "multiply": 0.8 }
|
||||
],
|
||||
"affects": ["Archer"],
|
||||
"soundComplete": "interface/alarm/alarm_upgradearmory.xml"
|
||||
|
@ -22,7 +22,7 @@
|
||||
"researchTime": 40,
|
||||
"tooltip": "Bolt Shooters −20% ranged attack spread.",
|
||||
"modifications": [
|
||||
{ "value": "Attack/Ranged/Spread", "multiply": 0.8 }
|
||||
{ "value": "Attack/Ranged/Projectile/Spread", "multiply": 0.8 }
|
||||
],
|
||||
"affects": ["BoltShooter"],
|
||||
"soundComplete": "interface/alarm/alarm_upgradearmory.xml"
|
||||
|
@ -7,7 +7,7 @@
|
||||
{ "value": "Attack/Melee/Damage/Hack", "multiply": 1.2, "affects": "Melee" },
|
||||
{ "value": "Attack/Melee/Damage/Pierce", "multiply": 1.2, "affects": "Melee" },
|
||||
{ "value": "Attack/Melee/Damage/Crush", "multiply": 1.2, "affects": "Melee" },
|
||||
{ "value": "Attack/Ranged/Spread", "multiply": 0.8, "affects": "Ranged" },
|
||||
{ "value": "Attack/Ranged/Projectile/Spread", "multiply": 0.8, "affects": "Ranged" },
|
||||
{ "value": "Cost/BuildTime", "multiply": 1.2 },
|
||||
{ "value": "Health/Max", "multiply": 1.25 },
|
||||
{ "value": "Heal/Range", "add": 3, "affects": "Healer" },
|
||||
|
@ -7,7 +7,7 @@
|
||||
{ "value": "Attack/Melee/Damage/Hack", "multiply": 1.2, "affects": "Melee" },
|
||||
{ "value": "Attack/Melee/Damage/Pierce", "multiply": 1.2, "affects": "Melee" },
|
||||
{ "value": "Attack/Melee/Damage/Crush", "multiply": 1.2, "affects": "Melee" },
|
||||
{ "value": "Attack/Ranged/Spread", "multiply": 0.8, "affects": "Ranged" },
|
||||
{ "value": "Attack/Ranged/Projectile/Spread", "multiply": 0.8, "affects": "Ranged" },
|
||||
{ "value": "Cost/BuildTime", "multiply": 1.2 },
|
||||
{ "value": "Health/Max", "multiply": 1.25 },
|
||||
{ "value": "Heal/Range", "add": 3, "affects": "Healer" },
|
||||
|
Loading…
Reference in New Issue
Block a user