elexis
a33fd55e81
Improves performance for Draw calls by 3-5% according to a shady benchmark. Improves memory layout, since the values are not on the heap anymore but in the using class. Reduces complexity of the implementation and increases type safety. Allows specifying default values at setting value construction time, refs D2242. Inspired by Vladislav introducing members that cached GetSetting values in c016a74309/D325, refs #4039, ee38f0db37/D763, refs 4225, a1c4c23ce4/D474, D406, which were formerly proposed to be removed in D2241. Differential Revision: https://code.wildfiregames.com/D2313 Tested on: clang 8.0.1, gcc 9.1.0, Jenkins vs2015 Comments By: Vladislav This was SVN commit r23005.
89 lines
2.3 KiB
C++
89 lines
2.3 KiB
C++
/* Copyright (C) 2019 Wildfire Games.
|
|
* This file is part of 0 A.D.
|
|
*
|
|
* 0 A.D. is free software: you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation, either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* 0 A.D. is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with 0 A.D. If not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "precompiled.h"
|
|
|
|
#include "CGUISetting.h"
|
|
|
|
#include "gui/CGUI.h"
|
|
|
|
template<typename T>
|
|
|
|
CGUISetting<T>::CGUISetting(IGUIObject& pObject, const CStr& Name, T& Value)
|
|
: m_pSetting(Value), m_Name(Name), m_pObject(pObject)
|
|
{
|
|
}
|
|
|
|
template<typename T>
|
|
bool CGUISetting<T>::FromString(const CStrW& Value, const bool SendMessage)
|
|
{
|
|
T settingValue;
|
|
|
|
if (!CGUI::ParseString<T>(&m_pObject.GetGUI(), Value, settingValue))
|
|
return false;
|
|
|
|
m_pObject.SetSetting<T>(m_Name, settingValue, SendMessage);
|
|
return true;
|
|
};
|
|
|
|
template<>
|
|
bool CGUISetting<CGUIColor>::FromJSVal(JSContext* cx, JS::HandleValue Value, const bool SendMessage)
|
|
{
|
|
CGUIColor settingValue;
|
|
if (Value.isString())
|
|
{
|
|
CStr name;
|
|
if (!ScriptInterface::FromJSVal(cx, Value, name))
|
|
return false;
|
|
|
|
if (!settingValue.ParseString(m_pObject.GetGUI(), name))
|
|
{
|
|
JSAutoRequest rq(cx);
|
|
JS_ReportError(cx, "Invalid color '%s'", name.c_str());
|
|
return false;
|
|
}
|
|
}
|
|
else if (!ScriptInterface::FromJSVal<CColor>(cx, Value, settingValue))
|
|
return false;
|
|
|
|
m_pObject.SetSetting<CGUIColor>(m_Name, settingValue, SendMessage);
|
|
return true;
|
|
};
|
|
|
|
template<typename T>
|
|
bool CGUISetting<T>::FromJSVal(JSContext* cx, JS::HandleValue Value, const bool SendMessage)
|
|
{
|
|
T settingValue;
|
|
if (!ScriptInterface::FromJSVal<T>(cx, Value, settingValue))
|
|
return false;
|
|
|
|
m_pObject.SetSetting<T>(m_Name, settingValue, SendMessage);
|
|
return true;
|
|
};
|
|
|
|
template<typename T>
|
|
void CGUISetting<T>::ToJSVal(JSContext* cx, JS::MutableHandleValue Value)
|
|
{
|
|
ScriptInterface::ToJSVal<T>(cx, Value, m_pSetting);
|
|
};
|
|
|
|
#define TYPE(T) \
|
|
template class CGUISetting<T>; \
|
|
|
|
#include "GUItypes.h"
|
|
#undef TYPE
|