• Joined on 2024-08-19
Dunedan pushed to exclude-map-xml-from-0ad-hook at Dunedan/0ad 2024-09-15 14:56:41 +02:00
efbc165a08 Exclude map XML files from non-breaking space hook
Dunedan commented on pull request 0ad/0ad#7002 2024-09-15 13:55:08 +02:00
WIP: Always use STUN for hosting games using the lobby

I might be wrong but I believe that's a specific case where you want the local ip to be used in the lobby because you're playing with a relative and other people on the internet.

Just so…

Dunedan created pull request 0ad/0ad#7048 2024-09-15 13:38:31 +02:00
Add EditorConfig options for Python
Dunedan created branch editorconfig-for-python in Dunedan/0ad 2024-09-15 13:38:15 +02:00
Dunedan pushed to editorconfig-for-python at Dunedan/0ad 2024-09-15 13:38:15 +02:00
2c233a99cd Add EditorConfig options for Python
Dunedan commented on pull request 0ad/0ad#7002 2024-09-15 13:12:56 +02:00
WIP: Always use STUN for hosting games using the lobby

Whether or not there is an XMPP client isn't related to the IP-addresses of game participants (what localNetwork seems to be about), but whether a game gets started through the lobby or not. So…

Dunedan commented on pull request 0ad/0ad#7046 2024-09-15 11:34:01 +02:00
Enable various ruff rules

I just noticed pre-commit has been failing after my recent commit fixing the Python version used for ruff check, so I just pushed another commit fixing that. I intend to split everything in this…

Dunedan pushed to enable-misc-ruff-rules at Dunedan/0ad 2024-09-15 11:32:15 +02:00
b5bb79ae6b Fix ruff errors caused checking for Python 3.11
3208241a62 Specify the target version in ruff.toml
Compare 2 commits »
Dunedan commented on pull request 0ad/0ad#7046 2024-09-13 21:54:52 +02:00
Enable various ruff rules

I'll put that in a separate commit right before I merge. 👍

Dunedan commented on pull request 0ad/0ad#7046 2024-09-13 21:54:23 +02:00
Enable various ruff rules

As it turns out I didn't account for the XML parsing when modifying the code. Thanks for noticing. 👍 It's a good example though why catching all exceptions ("except Exception:") is problematic,…

Dunedan pushed to enable-misc-ruff-rules at Dunedan/0ad 2024-09-13 21:46:47 +02:00
c8bb0116a0 Fix exception handling for invalid XML files
Dunedan commented on pull request 0ad/0ad#7046 2024-09-13 18:04:12 +02:00
Enable various ruff rules

spirv-tools is available, but spirv-reflect isn't part of spirv-tools.

Dunedan commented on pull request 0ad/0ad#7046 2024-09-13 18:03:00 +02:00
Enable various ruff rules

Please look closely at what I changed in detail. 😃

Dunedan commented on pull request 0ad/0ad#7046 2024-09-13 16:52:26 +02:00
Enable various ruff rules

I can't test it, because some parts of the necessary SPIR-V toolchain aren't available for Debian, but I expect compiling the shaders takes so much time that a switch from SHA1 to SHA256 for…

Dunedan commented on pull request 0ad/0ad#7046 2024-09-13 16:49:07 +02:00
Enable various ruff rules

Different commit or different PR? I don't mind splitting it out, but given how messy past commits sometimes were I feel like this is nitpicking. 😉

Dunedan commented on pull request 0ad/0ad#7046 2024-09-13 16:47:49 +02:00
Enable various ruff rules

My intention was that this change doesn't change the functionality at all. As far as I can see I achieved that, but maybe I'm wrong? Do you see anything which is different to before now?

Dunedan commented on pull request 0ad/0ad#7046 2024-09-13 16:44:48 +02:00
Enable various ruff rules

Yes, but this will only be needed once.

Dunedan created pull request 0ad/0ad#7046 2024-09-13 16:30:44 +02:00
Enable various ruff rules
Dunedan created branch enable-misc-ruff-rules in Dunedan/0ad 2024-09-13 16:29:26 +02:00
Dunedan pushed to enable-misc-ruff-rules at Dunedan/0ad 2024-09-13 16:29:26 +02:00
9a5bba49cc Enable various ruff rules
e56ebb3f46 Enable ruff naming rules
cd8b4266a4 Fix class name in xmlvalidator
8c7cc7373d Fix variable names in SPIRV compile.py
0d3e3fbc29 Rename simple-example.py
Compare 7 commits »