Nicolas Auvray Itms
  • Joined on 2024-08-19
Itms commented on pull request 0ad/0ad#7052 2024-09-16 23:32:18 +02:00
doxygen-improvement (D5252)

Thanks for the port to here! I will use the opportunity to setup the docs pipeline.

Itms commented on pull request 0ad/0ad#6996 2024-09-16 23:30:27 +02:00
Fix warnings on the CI, fixes #6987

I have only gone through fixing the remaining issues I knew about, and haven't addressed comments above yet.

Itms pushed to fix-warnings at Itms/0ad 2024-09-16 23:28:54 +02:00
d929c54571 Remove unused typedef in json_spirit
9f41012b79 Remove unused variables
d2afda3f4e Avoid a copy in a range-for-loop
92f34936bd Use lambda capture in tests
9759265efe Mark class with final dtor as final in tests
Compare 63 commits »
Itms created pull request 0ad/0ad#7053 2024-09-16 23:24:34 +02:00
Replace platform-dependant implementations of atomic operations with std::atomic
Itms created branch std-atomic in Itms/0ad 2024-09-16 23:09:46 +02:00
Itms pushed to std-atomic at Itms/0ad 2024-09-16 23:09:46 +02:00
6ba9a3214d Remove platform-dependant atomic operations
b19442cd47 Test std::atomic uses in lowlevel
a3541201a6 Use std::atomic instead of platform-dependant code
a942100921 Replace custom atomic_bool with std::atomic<bool>
183c2b5e8c Remove TIMER_ACCRUE_ATOMIC
Compare 10 commits »
Itms pushed to test-lfs-breakage at Itms/0ad 2024-09-15 15:57:18 +02:00
220251c557 add lfs file
Itms pushed to test-lfs-breakage at Itms/0ad 2024-09-15 15:52:02 +02:00
88987457b4 add another non-lfs file
Itms created branch test-lfs-breakage in Itms/0ad 2024-09-15 15:45:53 +02:00
Itms pushed to test-lfs-breakage at Itms/0ad 2024-09-15 15:45:53 +02:00
f377fda113 add non-lfs file
Itms commented on pull request 0ad/0ad#7018 2024-09-15 13:45:03 +02:00
Left-click the portrait to follow the entity

If the reviewer is OK then it's good to go. @sera do you want to merge this as your first team action? 😄

Itms opened issue 0ad/0ad#7039 2024-09-11 16:34:42 +02:00
mod.io API URL Update
Itms commented on pull request 0ad/0ad#7030 2024-09-10 19:41:10 +02:00
Increase height of middle panel to prevent icon overflow

Hmm, I don't see why the minimap and the middle panel had to be the same height before. The whole bottom part is anything but symmetrical, it even has a certain "skyline" look (not necessarily a…

Itms commented on pull request 0ad/0ad#7030 2024-09-09 21:36:55 +02:00
Increase height of middle panel to prevent icon overflow

No I mean increasing the height of the minimap panel but not changing the size of the contents. Just adding some padding.

Itms commented on pull request 0ad/0ad#7030 2024-09-09 21:12:08 +02:00
Increase height of middle panel to prevent icon overflow

I really like the change 👍

Now I am a bit bothered visually by the fact that the minimap panel now is not as high as the central panel. Maybe add 2px at the top and 2px at the bottom of…

Itms approved 0ad/0ad#7036 2024-09-09 20:44:21 +02:00
Speed up fetching of translations from Transifex

This needs a rebase upon main to go through CI. I am OK with the change though.

Itms commented on pull request 0ad/0ad#7037 2024-09-09 20:43:11 +02:00
Add the large address aware flag to the nightly build.

Btw any reason we're not build the gloox wrapper anymore?

The glooxwrapper is now already built (see current update-workspaces.bat). I plan to just remove it altogether, because we are not…

Itms approved 0ad/0ad#7037 2024-09-09 20:41:48 +02:00
Add the large address aware flag to the nightly build.

Ooops.

Itms commented on pull request 0ad/0ad#6974 2024-09-09 20:41:15 +02:00
Fix build on recent macOS.

I will include this when fixing #6895 👍 Can I close the PR to reduce the review queue?

Itms deleted branch build-split-libs-download from sera/0ad 2024-09-08 23:25:40 +02:00