I know this pull request is huge... but could someone take some time to review the code?
Hi Vantha, this one was easy to miss with no reviewers assigned. Should @ShadowOfHassen be assigned as…
@abian Feel free to pick up the work, as wraitii's patch is outdated and Vlad is currently MIA.
This is not relevant anymore after the migration to Gitea.
Where i recomended
reinterpret_castthe atomic might better be a pointer type.
I don't understand the need for a reinterpret_cast here. I am manipulating the address stored in the…
I noticed that this header (which was included to obtain cpu_CAS or cpu_AtomicAdd in many cases), was also unneeded here, so I removed it. Same thing for `source/lib/allocators/page_aligned.cpp…
Maybe. Do you have a list of the errors ?
ERROR: CCacheLoader failed to find archived or source file for: "shaders/spirv/compute_upscale_fsr.xml"
ERROR: Program 'spirv/compute_upscale_fs…Before I actually review: let's use the opportunity to fix the typo visibitily to visibility in the common utilities 🥲