Increase height of middle panel to prevent icon overflow #7030

abian · 2024-09-05T13:34:35+02:00

abian commented

2024-09-05 13:34:35 +02:00

Increase height of middle panel to prevent icon overflow

The icon/portrait of the middle panel when a single entity was selected
was very subtly (4 px) overflowing its lane and invading that of the
entity's name. This change fixes that by:

Raising the top of the middle panel by 4 px to leave room for the
portrait/icon. This avoids having to shrink it and lose quality.
Distributing the 4 px of difference in height in the statistics area
by lowering 1 px the top bar, 1 px the middle bar (if any), and 3 px
the bottom bar (if any). The rest of the elements are lowered 4 px,
and therefore remain in the same place.
Increasing the height of the minimap panel by 4 px so that it remains
aligned with the middle panel, vertically centering the minimap, and
making the necessary adjustments to the position of its buttons.

Additionally, a couple of minor changes are applied:

The separators between the statistics area and the attack/resistance
and resources area, and between the attack/resistance and resources
area and the entity name area, which had different heights, are set
to the same height/thickness.
The attack/resistance icon, which was very close to the entity
icon/portrait, is moved 1 px to the right, and the
resourceCarryingText (in the same area), which was very far from the
resourceCarryingIcon, is also moved 3 px to the right.

Fixes #7029

Increase height of middle panel to prevent icon overflow The icon/portrait of the middle panel when a single entity was selected was very subtly (4 px) overflowing its lane and invading that of the entity's name. This change fixes that by: - Raising the top of the middle panel by 4 px to leave room for the portrait/icon. This avoids having to shrink it and lose quality. - Distributing the 4 px of difference in height in the statistics area by lowering 1 px the top bar, 1 px the middle bar (if any), and 3 px the bottom bar (if any). The rest of the elements are lowered 4 px, and therefore remain in the same place. - Increasing the height of the minimap panel by 4 px so that it remains aligned with the middle panel, vertically centering the minimap, and making the necessary adjustments to the position of its buttons. Additionally, a couple of minor changes are applied: - The separators between the statistics area and the attack/resistance and resources area, and between the attack/resistance and resources area and the entity name area, which had different heights, are set to the same height/thickness. - The attack/resistance icon, which was very close to the entity icon/portrait, is moved 1 px to the right, and the resourceCarryingText (in the same area), which was very far from the resourceCarryingIcon, is also moved 3 px to the right. Fixes #7029

🤯 1

abian added 1 commit 2024-09-05 13:34:42 +02:00

Fix icon/portrait subtly overflowing its lane in the central panel

0ad-linux/pipeline/pr-main There was a failure building this commit

Details

0ad-freebsd/pipeline/pr-main This commit looks good

Details

0ad-macos/pipeline/pr-main This commit was not built

Details

0ad-windows/pipeline/pr-main This commit was not built

Details

checkrefs / checkrefs (pull_request) Successful in 1m5s

Details

pre-commit / build (pull_request) Successful in 1m18s

Details

fab1275429

The icon/portrait of the central panel is very subtly (4px) overflowing
its lane and invading that of the entity's name. This change fixes that.

Fixes #7029

abian requested review from Imarok 2024-09-05 13:34:46 +02:00

abian requested review from s0600204 2024-09-05 13:34:46 +02:00

abian requested review from wraitii 2024-09-05 13:34:46 +02:00

abian requested review from marder 2024-09-05 13:34:46 +02:00

abian removed review request for Imarok 2024-09-05 13:34:51 +02:00

abian removed review request for wraitii 2024-09-05 13:35:01 +02:00

abian removed review request for s0600204 2024-09-05 13:35:02 +02:00

abian removed review request for marder 2024-09-05 13:35:04 +02:00

abian force-pushed portrait-overflowing from fab1275429 to ffad17dbf4

2024-09-05 13:35:22 +02:00

Compare

phosit added a new dependency 2024-09-05 18:27:11 +02:00

#6931 Clicking the button 'Trade Dialog' results in warnings

phosit removed a dependency 2024-09-05 18:27:29 +02:00

#6931 Clicking the button 'Trade Dialog' results in warnings

sera commented

2024-09-06 06:34:01 +02:00

The portraits have a size of 256x256, so changing form 96 to 92 means changing gcf from 32 to 4, which might degrade the picture quality. Someone with an eye for art should have a look. I usually still can't really tell the difference when others cry butcher.

I agree on the overflow being an issue tho.

The portraits have a size of 256x256, so changing form 96 to 92 means changing gcf from 32 to 4, which might degrade the picture quality. Someone with an eye for art should have a look. I usually still can't really tell the difference when others cry butcher. I agree on the overflow being an issue tho.

👍 1

Itms commented

2024-09-08 08:56:41 +02:00

I agree with sera, I think it would be better to raise the top of the central panel by 4 px to leave room. It's up to you whether HP and CP bars should be raised and follow the portrait, or should stay here with extra top padding.

👍 1

abian force-pushed portrait-overflowing from ffad17dbf4 to 848baa0705

2024-09-09 13:44:13 +02:00

Compare

abian changed title from ~~Fix icon/portrait subtly overflowing its lane in the central panel~~ to Increase height of middle panel to prevent icon overflow

2024-09-09 13:49:57 +02:00

abian force-pushed portrait-overflowing from 848baa0705 to ecafbc15f4

2024-09-09 13:51:26 +02:00

Compare

abian requested review from Itms 2024-09-09 13:51:52 +02:00

abian requested review from sera 2024-09-09 13:51:52 +02:00

Itms commented

2024-09-09 21:12:08 +02:00

I really like the change 👍

Now I am a bit bothered visually by the fact that the minimap panel now is not as high as the central panel. Maybe add 2px at the top and 2px at the bottom of that panel to bring it to 204px as well... But I'm not sure that's meaningful. @Stan what do you think?

I really like the change 👍 Now I am a bit bothered visually by the fact that the minimap panel now is not as high as the central panel. Maybe add 2px at the top and 2px at the bottom of that panel to bring it to 204px as well... But I'm not sure that's meaningful. @Stan what do you think?

Stan commented

2024-09-09 21:18:58 +02:00

If you do this, the minimap will no longer be square, which might cause issues with the buttons, won't it ?

Itms commented

2024-09-09 21:36:55 +02:00

No I mean increasing the height of the minimap panel but not changing the size of the contents. Just adding some padding.

abian commented

2024-09-10 12:26:55 +02:00

Hmm, I don't see why the minimap and the middle panel had to be the same height before. The whole bottom part is anything but symmetrical, it even has a certain "skyline" look (not necessarily a bad thing).

Itms commented

2024-09-10 19:41:10 +02:00

Hmm, I don't see why the minimap and the middle panel had to be the same height before. The whole bottom part is anything but symmetrical, it even has a certain "skyline" look (not necessarily a bad thing).

I think I have the same opinion. But the fact I noticed the newly introduced discrepancy is a sign we might need the input of users here.

> Hmm, I don't see why the minimap and the middle panel had to be the same height before. The whole bottom part is anything but symmetrical, it even has a certain "skyline" look (not necessarily a bad thing). I think I have the same opinion. But the fact I noticed the newly introduced discrepancy is a sign we might need the input of users here.

Itms commented

2024-09-17 17:32:25 +02:00

@Stan Here are screens for an artist's opinion.

before.png

1.4 MiB

after.png

1.4 MiB

🪙 2

Stan commented

2024-09-17 17:40:14 +02:00

I asked artsy people and they think you should raise the minimap box by 2px as well :)

👍 1