abian/0ad
1
0
Fork 0
forked from 0ad/0ad
Code Pull Requests Activity

Scroll to the selected element after the selection changes. Fixes #4254, refs #3742.

Browse Source 
This was SVN commit r18935.
This commit is contained in:
elexis 2016-11-14 15:28:49 +00:00
parent a89f521e08
commit 3f5648767d
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
source/gui/CList.cpp
View File

@ -1,4 +1,4 @@
/* Copyright (C) 2015 Wildfire Games.
/* Copyright (C) 2016 Wildfire Games.
* This file is part of 0 A.D.
*
* 0 A.D. is free software: you can redistribute it and/or modify
@ -152,6 +152,8 @@ void CList::HandleMessage(SGUIMessage& Message)
{
// TODO: Check range
UpdateAutoScroll();
// TODO only works if lower-case, shouldn't it be made case sensitive instead?
ScriptEvent("selectionchange");
}
@ -486,10 +488,8 @@ void CList::UpdateAutoScroll()
GUI<int>::GetSetting(this, "selected", selected);
GUI<bool>::GetSetting(this, "scrollbar", scrollbar);
CRect rect = GetListRect();
// No scrollbar, no scrolling (at least it's not made to work properly).
if (!scrollbar)
if (!scrollbar || selected < 0 || (std::size_t) selected >= m_ItemsYPositions.size())
return;
scroll = GetScrollBar(0).GetPos();
@ -503,6 +503,7 @@ void CList::UpdateAutoScroll()
}
// Check lower boundary
CRect rect = GetListRect();
if (m_ItemsYPositions[selected+1]-rect.GetHeight() > scroll)
GetScrollBar(0).SetPos(m_ItemsYPositions[selected+1]-rect.GetHeight());
}