• Joined on 2024-08-19
phosit pushed to atlas_biome_dropdown at phosit/0ad 2024-09-24 20:16:44 +02:00
472af5e5ef Remove setSelectedBiome
7c211c9edd Allow selecting a biome in Atlas
Compare 2 commits »
phosit commented on pull request 0ad/0ad#7059 2024-09-24 18:04:13 +02:00
Adopt generator based interface by mapgen tests

There are only prefer-const warnings, which are unrelated and should be fixed in an other commit.

phosit commented on issue 0ad/0ad#6472 2024-09-23 21:37:29 +02:00
ES Module Support

Wouldn't this prevent mods? When a script currently calls Engine.LoadLibrary, all files in that directory are evaluated. Also files which are in a mod. When it will include a module only…

phosit commented on pull request 0ad/0ad#7059 2024-09-23 19:24:34 +02:00
Adopt generator based interface by mapgen tests

Here is the stack trace:

Thanks a lot. Also for the time at the weekend when you searched which change introduced the build failure.

phosit pushed to more_promises at phosit/0ad 2024-09-23 18:50:55 +02:00
706ea7c758 Make progressDialog return a promise
78ef0c1682 Return a promise from setButtonCaptionsAndVisibility
Compare 2 commits »
phosit commented on pull request 0ad/0ad#7053 2024-09-23 18:01:24 +02:00
Replace platform-dependant implementations of atomic operations with std::atomic

Where i recomended reinterpret_cast the atomic might better be a pointer type.

I don't understand the need for a reinterpret_cast here. I am manipulating the address stored in the…

phosit pushed to structured_gui-pages_with_classes at phosit/0ad 2024-09-23 17:54:13 +02:00
e3d4719aa9 Remove Engine.PopGuiPage
a91d849489 Return a promise from most page-inits
883f093cb9 Change the GuiManager tests to use promises
b28b2343d8 Enable page-inits to return a Promise
Compare 4 commits »
phosit pushed to more_promises at phosit/0ad 2024-09-23 17:53:13 +02:00
c1132daeab Make progressDialog return a promise
f2e260a251 Return a promise from setButtonCaptionsAndVisibility
Compare 2 commits »
phosit pushed to atlas_biome_dropdown at phosit/0ad 2024-09-22 14:54:02 +02:00
30a63187ab Remove setSelectedBiome
1b86fc70fd Allow selecting a biome in Atlas
Compare 2 commits »
phosit commented on pull request 0ad/0ad#7065 2024-09-22 14:39:30 +02:00
Allow selecting a biome in Atlas

There is no MapHandlers.h But yes i shouldn't depend on implicit inclusion.

phosit commented on pull request 0ad/0ad#7062 2024-09-22 13:40:57 +02:00
WIP: Pick a TeamPlacement in Atlas

Yes needs I'll rework this pr to implement a dropdown. Then it doesn't need a random number generator.

phosit commented on pull request 0ad/0ad#7053 2024-09-22 13:35:59 +02:00
Replace platform-dependant implementations of atomic operations with std::atomic

Why do you change this file?

phosit commented on pull request 0ad/0ad#7053 2024-09-22 13:35:59 +02:00
Replace platform-dependant implementations of atomic operations with std::atomic

use pre-decrement

phosit commented on pull request 0ad/0ad#7053 2024-09-22 13:35:59 +02:00
Replace platform-dependant implementations of atomic operations with std::atomic

reinterpret_cast<uintptr_t>

phosit commented on pull request 0ad/0ad#7053 2024-09-22 13:35:59 +02:00
Replace platform-dependant implementations of atomic operations with std::atomic

reinterpret_cast<uintptr_t>

phosit commented on pull request 0ad/0ad#7053 2024-09-22 13:35:59 +02:00
Replace platform-dependant implementations of atomic operations with std::atomic

reinterpret_cast<void*>

phosit commented on pull request 0ad/0ad#7053 2024-09-22 13:35:59 +02:00
Replace platform-dependant implementations of atomic operations with std::atomic

Where i recomended reinterpret_cast the atomic might better be a pointer type.

phosit commented on pull request 0ad/0ad#7065 2024-09-22 12:33:39 +02:00
Allow selecting a biome in Atlas

I included algorithm iostream was a leftover string and vector are included in messages.h

phosit pushed to atlas_biome_dropdown at phosit/0ad 2024-09-22 12:31:46 +02:00
6abc9a1e29 Remove setSelectedBiome
c7723b19e4 Allow selecting a biome in Atlas
Compare 2 commits »
phosit pushed to map_generator at phosit/0ad 2024-09-22 12:15:03 +02:00
201d215f29 Adopt generator based interface by mapgen tests