Add chat notifications for flares #7041

Open

Vantha wants to merge 2 commits from Vantha/0ad:flare-notifications into main

pull from: Vantha/0ad:flare-notifications

merge into: 0ad:main

0ad:main

0ad:diversify-linux

Conversation 4 Commits 2 Files Changed 9 +98 -43

Vantha commented 2024-09-12 17:56:41 +02:00

Member

Copy Link

No description provided.

👍 1

Vantha added 1 commit 2024-09-12 17:56:46 +02:00

Add chat notifications for flares db3717b916

Vantha requested review from marder 2024-09-12 17:56:47 +02:00

Vantha requested review from Imarok 2024-09-12 17:56:47 +02:00

Vantha requested review from s0600204 2024-09-12 17:56:47 +02:00

Vantha requested review from wraitii 2024-09-12 17:56:47 +02:00

Vantha removed review request for wraitii 2024-09-12 17:56:55 +02:00

Vantha removed review request for s0600204 2024-09-12 17:56:56 +02:00

Vantha removed review request for Imarok 2024-09-12 17:56:57 +02:00

Vantha removed review request for marder 2024-09-12 17:56:59 +02:00

Vantha commented 2024-09-12 18:03:12 +02:00

Author

Member

Copy Link

This patch adds a setting (enabled by default) for flare chat notifications.
It's meant as a base for #7042 - a way to tell which observer sent a flare (since all observers flare in white).
The 'Game Session' settings category doesn't have space on the GUI page for a new setting which is why I moved all chat related settings (including the new one) into a new settings category called 'Chat'.

Points to discuss:

• Should there be a option to only recieve the chat notifications when one is an observer? (And maybe use dropdown instead of a checkbox?)
• Is the new settings category alright?

**This patch adds a setting (enabled by default) for flare chat notifications.** It's meant as a base for #7042 - a way to tell which observer sent a flare (since all observers flare in white). The 'Game Session' settings category doesn't have space on the GUI page for a new setting which is why I moved all chat related settings (including the new one) into a new settings category called 'Chat'. Points to discuss: - Should there be a option to only recieve the chat notifications when one is an observer? (And maybe use dropdown instead of a checkbox?) - Is the new settings category alright?

Vantha referenced this pull request 2024-09-12 18:07:01 +02:00

Enable observers to see and send flares #7042

Vantha added a new dependency 2024-09-12 18:07:10 +02:00

#7042 Enable observers to see and send flares

Vantha added the

Theme

UI & Simulation

label 2024-09-13 12:27:02 +02:00

abian commented 2024-09-15 14:24:15 +02:00

Contributor

Copy Link

Good idea! I think it would be nice to add an icon like icon_focusattacked and be able to click on the message to focus the camera on the flare.

Good idea! I think it would be nice to add an icon like `icon_focusattacked` and be able to click on the message to focus the camera on the flare.

Vantha commented 2024-09-16 00:21:08 +02:00

Author

Member

Copy Link

Good idea! I think it would be nice to add an icon like icon_focusattacked and be able to click on the message to focus the camera on the flare.

Wow, clicking on the attack notification actually makes the camera jump to the attacked unit... how did I not know about this feature?
(could maybe also be included in the tips)

Anyway, in that case, I agree, making the flare message clickable too is definitely something that I should do.
Thanks.

> Good idea! I think it would be nice to add an icon like `icon_focusattacked` and be able to click on the message to focus the camera on the flare. Wow, clicking on the attack notification actually makes the camera jump to the attacked unit... how did I not know about this feature? (could maybe also be included in the tips) Anyway, in that case, I agree, making the flare message clickable too is definitely something that I should do. Thanks.

❤️ 1

Vantha added 1 commit 2024-09-16 16:39:56 +02:00

Make the chat notification clickable 0364ed1be2

Vantha commented 2024-09-16 16:46:41 +02:00

Author

Member

Copy Link

Added an icon to the beginning of the chat message (sprite extracted from the minimap flare button. Though, I'm not fully content with it):

And also made the camera move to the flare's location when left-clicking on the notification:

Added an icon to the beginning of the chat message (sprite extracted from the minimap flare button. Though, I'm not fully content with it):  And also made the camera move to the flare's location when left-clicking on the notification: 

screenshot0004.png

29 KiB

screenshot0005.png

47 KiB

🎉 1

Some checks failed

Hide all checks

0ad-freebsd/pipeline/pr-main There was a failure building this commit

Details

0ad-macos/pipeline/pr-main There was a failure building this commit

Details

0ad-linux/pipeline/pr-main There was a failure building this commit

Required

Details

checkrefs / checkrefs (pull_request) Successful in 1m17s

Required

Details

pre-commit / build (pull_request) Successful in 1m35s

Required

Details

0ad-windows/pipeline/pr-main This commit looks good

Details

Some required checks were not successful.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u flare-notifications:Vantha-flare-notifications

git checkout Vantha-flare-notifications

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Closed

Duplicate

  

Closed

Fixed

  

Closed

Invalid

  

Closed

Needs info

  

Closed

Won't fix

  

Closed

Works for me

  

Difficulty

Hard

  

Difficulty

Medium

  

Difficulty

Simple

  

Needed for Beta

  

Needs Design Input

  

Needs Info

  

Pathfinding

  

Priority

1: Release Blocker

  

Priority

2: Must Have

  

Priority

3: Should Have

  

Priority

4: Nice To Have

  

Priority

5: If Time Permits

  

Regression

  

Theme

AI

  

Theme

Art & Animation

  

Theme

Atlas editor

  

Theme

Build & Packages

  

Theme

Core engine

  

Theme

Internationalization & Localization

  

Theme

Maps

  

Theme

Multiplayer Lobby

  

Theme

Music & Sound FX

  

Theme

Network

  

Theme

Non-game systems

  

Theme

Simulation

  

Theme

UI & Simulation

  

Theme

UI – Game setup

  

Theme

UI – In-game

  

Theme

UI – Miscellaneous

  

Theme

Website & Forum

  

Type

Defect

  

Type

Enhancement

  

Type

Task

No Label

Closed

Duplicate

Closed

Fixed

Closed

Invalid

Closed

Needs info

Closed

Won't fix

Closed

Works for me

Difficulty

Hard

Difficulty

Medium

Difficulty

Simple

Needed for Beta

Needs Design Input

Needs Info

Pathfinding

Priority

1: Release Blocker

Priority

2: Must Have

Priority

3: Should Have

Priority

4: Nice To Have

Priority

5: If Time Permits

Regression

Theme

AI

Theme

Art & Animation

Theme

Atlas editor

Theme

Build & Packages

Theme

Core engine

Theme

Internationalization & Localization

Theme

Maps

Theme

Multiplayer Lobby

Theme

Music & Sound FX

Theme

Network

Theme

Non-game systems

Theme

Simulation

Theme

UI & Simulation

Theme

UI – Game setup

Theme

UI – In-game

Theme

UI – Miscellaneous

Theme

Website & Forum

Type

Defect

Type

Enhancement

Type

Task

Milestone

Clear milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

No Assignees

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Blocks

#7042 Enable observers to see and send flares

0ad/0ad

Reference: 0ad/0ad#7041

No description provided.