• Joined on 2024-08-19
Dunedan commented on pull request 0ad/0ad#6970 2024-08-25 15:41:10 +02:00
Enable ruff rules to check for ambiguous code

Is this var_ a common escape pattern?

Let's say some people (like me) use it to avoid naming collisions, when they have no idea how they should name the variable otherwise. I'd be happy about…

Dunedan created branch checkref in Dunedan/0ad 2024-08-25 15:38:54 +02:00
Dunedan pushed to checkref at Dunedan/0ad 2024-08-25 15:38:54 +02:00
a0d6da0d0c Remove self.roots
a8249100f0 Better unused
cdf26dd3dd Simplify check_deps()
3f6527c126 Refactor check_deps for more performance
9ba2c87941 Simplify check functions
Compare 10 commits »
Dunedan pushed to enable-ruff-checks-for-ambiguous-code at Dunedan/0ad 2024-08-25 14:06:57 +02:00
c99740d25c Address review comments
Dunedan commented on pull request 0ad/0ad#6970 2024-08-25 14:05:05 +02:00
Enable ruff rules to check for ambiguous code

__init_logger was defined as a property. Getting the value of a property indeed doesn't need parenthesis, however using a property for that use case is pretty odd as __init_logger neither…

Dunedan deleted branch add-more-ruff-checks from Dunedan/0ad 2024-08-25 13:40:45 +02:00
Dunedan created pull request 0ad/0ad#6970 2024-08-25 08:35:06 +02:00
Enable ruff rules to check for ambiguous code
Dunedan created branch enable-ruff-checks-for-ambiguous-code in Dunedan/0ad 2024-08-25 08:34:11 +02:00
Dunedan pushed to enable-ruff-checks-for-ambiguous-code at Dunedan/0ad 2024-08-25 08:34:11 +02:00
fe3245428e Enable ruff rules to check for ambiguous code
Dunedan pushed to main at 0ad/0ad 2024-08-25 06:31:40 +02:00
e36c6a31fe Enable additional ruff rules
Dunedan 2024-08-25 06:31:38 +02:00
Dunedan pushed to add-more-ruff-checks at Dunedan/0ad 2024-08-25 06:30:17 +02:00
e36c6a31fe Enable additional ruff rules
Dunedan closed pull request 0ad/0ad#6952 2024-08-25 06:27:47 +02:00
Deny hosting a game if a player is muted
Dunedan commented on pull request 0ad/0ad#6952 2024-08-25 06:27:46 +02:00
Deny hosting a game if a player is muted

I think that we should have a progression to the severity of punishment, which can be applied based on the severity of the misconduct. This is the progression that I suggest.

1.…

Dunedan commented on pull request 0ad/0ad#6958 2024-08-24 21:25:06 +02:00
Run shfmt on tree and add it to pre-commit

This hook comes with some properties by default we should overwrite:

Dunedan commented on pull request 0ad/0ad#6958 2024-08-24 21:25:06 +02:00
Run shfmt on tree and add it to pre-commit

Please remove this comment. It doesn't add much value.

Dunedan suggested changes for 0ad/0ad#6958 2024-08-24 21:25:06 +02:00
Run shfmt on tree and add it to pre-commit
Dunedan commented on pull request 0ad/0ad#6967 2024-08-24 20:45:52 +02:00
Add a bunch of additional pre-commit hooks

Maybe we should ignore bat files, as they should probably still be considered executable? Even if Windows doesn't care at all.

If Windows doesn't care, why should they have the executable bit…

Dunedan commented on pull request 0ad/0ad#6968 2024-08-24 20:40:50 +02:00
Enable additional ruff rules

Don't have much to say about the linter itself. Are the ignored rules too hard to fix ?

In most cases it's pretty straight-forward. It's just pretty tedious given the amount of changes…

Dunedan commented on pull request 0ad/0ad#6968 2024-08-24 20:12:33 +02:00
Enable additional ruff rules

Well, not that weird and especially useful for packing pretty commonly used for packing and unpacking function arguments. The ruff rule responsible for this is: https://docs.astral.sh/ruff/rules/c